fix(docker,titus): re-align digest field on image + tag selector #7526
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
christopherthielen
approved these changes
Oct 15, 2019
christopherthielen
added a commit
to christopherthielen/deck
that referenced
this pull request
Oct 15, 2019
c7feedd fix(docker,titus): re-align digest field on image + tag selector (spinnaker#7526)
christopherthielen
added a commit
to christopherthielen/deck
that referenced
this pull request
Oct 15, 2019
c7feedd fix(docker,titus): re-align digest field on image + tag selector (spinnaker#7526)
yunzhangit
pushed a commit
to yunzhangit/deck
that referenced
this pull request
Mar 28, 2021
yunzhangit
pushed a commit
to yunzhangit/deck
that referenced
this pull request
Mar 28, 2021
c7feedd fix(docker,titus): re-align digest field on image + tag selector (spinnaker#7526)
yunzhangit
pushed a commit
to yunzhangit/deck
that referenced
this pull request
Mar 28, 2021
c7feedd fix(docker,titus): re-align digest field on image + tag selector (spinnaker#7526)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
there were some odd hijinks in the docker image selector that seemed to be for compatibility with old bootstrap layouts. AFAICT that stuff no longer applies / is useful and has been causing some cool field alignment issues. Yanked it out and went through the usage of
DockerImageAndTagSelector, seems to have not broken anything.Before:
After:
