-
Notifications
You must be signed in to change notification settings - Fork 902
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(provider/ecs): add support for services with multiple target groups #7692
Conversation
The following commits need their title changed:
Please format your commit title into the form:
This allows us to easily generate changelogs & determine semantic version numbers when cutting releases. You can read more about commit conventions here. |
app/scripts/modules/ecs/src/serverGroup/configure/wizard/container/container.component.html
Show resolved
Hide resolved
...ts/modules/ecs/src/serverGroup/configure/wizard/networking/networkingSelector.component.html
Show resolved
Hide resolved
...ts/modules/ecs/src/serverGroup/configure/wizard/networking/networkingSelector.component.html
Show resolved
Hide resolved
@allisaurus would also be helpful to review this one |
33b4e73
to
11b7e8b
Compare
app/scripts/modules/ecs/src/serverGroup/configure/wizard/container/Container.tsx
Outdated
Show resolved
Hide resolved
app/scripts/modules/ecs/src/serverGroup/configure/wizard/container/Container.tsx
Show resolved
Hide resolved
app/scripts/modules/ecs/src/serverGroup/configure/wizard/taskDefinition/TaskDefinition.tsx
Show resolved
Hide resolved
app/scripts/modules/ecs/src/serverGroup/configure/wizard/taskDefinition/TaskDefinition.tsx
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Per offline discussion, please add (successful) test output for deployments using EC2/bridge mode and an artifact (together or separate).
Other than that, LGMT save a couple nits re: falsey checks.
app/scripts/modules/ecs/src/serverGroup/configure/wizard/container/Container.tsx
Show resolved
Hide resolved
app/scripts/modules/ecs/src/serverGroup/configure/wizard/container/Container.tsx
Show resolved
Hide resolved
Confirmed. Bridge mode and Artifacts still work |
…ups (spinnaker#7692) * feat(provider/ecs): Implement multiple target group support in spinnaker * Fix rebase issues * feat(provider/ecs): Implement multiple target group support in spinnaker * Fix rebase issues * Add alert if no target groups are available * remove duplicate * Update add new target mappings
Fixes: spinnaker/spinnaker#4788
Should be merged in with: spinnaker/clouddriver#4218
Task Definition Artifact:
![Artifact Screenshot](https://user-images.githubusercontent.com/44981951/70646363-9b08ae00-1bfb-11ea-9afb-ea5f332cb396.png)
Container Inputs:
![Container Inputs Screenshot](https://user-images.githubusercontent.com/44981951/70646364-9b08ae00-1bfb-11ea-9fa4-e676b112450f.png)
Alert if No Target Groups are available:
![No TG Available](https://user-images.githubusercontent.com/44981951/70954060-7871fd00-2020-11ea-9d6b-088bb7455c6d.png)