feat(provider/ecs): add support for services with multiple target groups #7692
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The following commits need their title changed:
Please format your commit title into the form:
This allows us to easily generate changelogs & determine semantic version numbers when cutting releases. You can read more about commit conventions here. |
app/scripts/modules/ecs/src/serverGroup/configure/wizard/container/container.component.html
Show resolved
Hide resolved
...ts/modules/ecs/src/serverGroup/configure/wizard/networking/networkingSelector.component.html
Show resolved
Hide resolved
...ts/modules/ecs/src/serverGroup/configure/wizard/networking/networkingSelector.component.html
Show resolved
Hide resolved
|
@allisaurus would also be helpful to review this one |
piradeepk
force-pushed
the
master
branch
5 times, most recently
from
33b4e73
to
11b7e8b
Compare
allisaurus
reviewed
Dec 16, 2019
app/scripts/modules/ecs/src/serverGroup/configure/wizard/container/Container.tsx
Outdated
Show resolved
Hide resolved
app/scripts/modules/ecs/src/serverGroup/configure/wizard/container/Container.tsx
Show resolved
Hide resolved
app/scripts/modules/ecs/src/serverGroup/configure/wizard/taskDefinition/TaskDefinition.tsx
Show resolved
Hide resolved
app/scripts/modules/ecs/src/serverGroup/configure/wizard/taskDefinition/TaskDefinition.tsx
Show resolved
Hide resolved
clareliguori
approved these changes
Dec 17, 2019
allisaurus
reviewed
Dec 17, 2019
app/scripts/modules/ecs/src/serverGroup/configure/wizard/container/Container.tsx
Show resolved
Hide resolved
app/scripts/modules/ecs/src/serverGroup/configure/wizard/container/Container.tsx
Show resolved
Hide resolved
Confirmed. Bridge mode and Artifacts still work |
allisaurus
approved these changes
Dec 18, 2019
3 tasks
6 tasks
yunzhangit
pushed a commit
to yunzhangit/deck
that referenced
this pull request
Mar 28, 2021
…ups (spinnaker#7692) * feat(provider/ecs): Implement multiple target group support in spinnaker * Fix rebase issues * feat(provider/ecs): Implement multiple target group support in spinnaker * Fix rebase issues * Add alert if no target groups are available * remove duplicate * Update add new target mappings
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: spinnaker/spinnaker#4788
Should be merged in with: spinnaker/clouddriver#4218
Task Definition Artifact:
Container Inputs:
Alert if No Target Groups are available:
