feat(core/managed): remove non-deploying state indicators #8101
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
After looking at them in the wild we decided we don't really like having indicators on the left side of every resource for every artifact state. It gets pretty busy:
Instead we're now removing them entirely for all states except
deploying. Right now we can't show deployment progress at the resource level, so these indicators are kind of silly and static, but once we get there we'll treat them as pie chart progress indicators and some fanciness will ensue.I also took the liberty of making the remaining indicator line up better with its surroundings, so the resource + notice card icons are back in proper alignment and the left edge of the indicator lines up with the left edge of environment rows:
(cc @gcomstock )