Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(ecs): move service discovery configuration to react #8188

Merged
merged 2 commits into from
Apr 27, 2020

Conversation

piradeepk
Copy link
Contributor

Updated the service discovery section of the configure server group wizard to react. Created and updated a server group using both the existing UI and the updated UI and the generated json is the same.

       "serviceDiscoveryAssociations": [
        {
          "containerPort": 80,
          "registry": {
            "account": "ecs-my-aws-devel-acct",
            "arn": "arn:aws:servicediscovery:us-west-2:164281909131:service/srv-mmr3glofrvzvtpdv",
            "displayName": "spinnaker-ecs-ec2-demo-svc (srv-mmr3glofrvzvtpdv)",
            "id": "srv-mmr3glofrvzvtpdv",
            "name": "spinnaker-ecs-ec2-demo-svc",
            "region": "us-west-2"
          }
        }
      ],

Screen Shot 2020-04-16 at 10 07 41 AM

Screen Shot 2020-04-16 at 10 07 53 AM

Screen Shot 2020-04-16 at 10 08 15 AM

Resolves: spinnaker/spinnaker#5482

@spinnakerbot
Copy link
Contributor

The following commits need their title changed:

Please format your commit title into the form:

<type>(<scope>): <subject>, e.g. fix(kubernetes): address NPE in status check

This allows us to easily generate changelogs & determine semantic version numbers when cutting releases. You can read more about commit conventions here.

@piradeepk piradeepk force-pushed the master branch 3 times, most recently from e75772b to 87b3d59 Compare April 17, 2020 20:43
@piradeepk
Copy link
Contributor Author

@allisaurus and @clareliguori please review

@allisaurus allisaurus self-requested a review April 21, 2020 17:33
const registryMap = this.getNameToRegistryMap();
let newServiceDiscoveryRegistry = registryMap.get(newRegistry.value);

if (!newServiceDiscoveryRegistry) {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

since this is firing when the registry drop-down is changed, when would we not find the registry? could newRegistry be search input (vs. an existing option)?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I was trying to maintain consistency with how the other properties are loaded in the configuration wizard currently (artifacts, container mappings, etc)

@piradeepk piradeepk force-pushed the master branch 3 times, most recently from 4140960 to 511b9cc Compare April 26, 2020 18:14
@allisaurus allisaurus added the ready to merge Reviewed and ready for merge label Apr 27, 2020
@mergify mergify bot merged commit 4d15ea1 into spinnaker:master Apr 27, 2020
yunzhangit pushed a commit to yunzhangit/deck that referenced this pull request Mar 28, 2021
* fix(ecs): move service discovery configuration to react

* Address feedback
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ready to merge Reviewed and ready for merge target-release/1.20
Projects
None yet
3 participants