chore(dependencies): Upgrade Spring Boot to 2.2.1 (#702)

See spinnaker/spinnaker#5134 Dependent on spinnaker/kork#419 for a Spring Boot dependency upgrade
spinnaker · Dec 10, 2019 · a8d0c89 · a8d0c89
1 parent c62ec67
commit a8d0c89
Show file tree

Hide file tree

Showing 3 changed files with 4 additions and 9 deletions.
diff --git a/echo-pubsub-core/src/main/java/com/netflix/spinnaker/echo/pubsub/PubsubMessageHandler.java b/echo-pubsub-core/src/main/java/com/netflix/spinnaker/echo/pubsub/PubsubMessageHandler.java
@@ -31,6 +31,7 @@
 import java.util.zip.CRC32;
 import lombok.extern.slf4j.Slf4j;
 import org.springframework.stereotype.Service;
+import redis.clients.jedis.params.SetParams;
 
 /** Shared cache of received and handled pubsub messages to synchronize clients. */
 @Slf4j
@@ -41,8 +42,6 @@ public class PubsubMessageHandler {
   private final Registry registry;
   private final List<EventCreator> eventCreators;
 
-  private static final String SET_IF_NOT_EXIST = "NX";
-  private static final String SET_EXPIRE_TIME_SECONDS = "EX";
   private static final String SUCCESS = "OK";
 
   @Service
@@ -131,11 +130,7 @@ private Boolean acquireMessageLock(
         redisClientDelegate.withCommandsClient(
             c -> {
               return c.set(
-                  messageKey,
-                  identifier,
-                  SET_IF_NOT_EXIST,
-                  SET_EXPIRE_TIME_SECONDS,
-                  ackDeadlineSeconds);
+                  messageKey, identifier, SetParams.setParams().nx().ex(ackDeadlineSeconds));
             });
     return SUCCESS.equals(response);
   }

diff --git a/...src/test/groovy/com/netflix/spinnaker/echo/pubsub/redis/EmbeddedRedisConfiguration.groovy b/...src/test/groovy/com/netflix/spinnaker/echo/pubsub/redis/EmbeddedRedisConfiguration.groovy
@@ -20,7 +20,7 @@ import com.netflix.spinnaker.kork.jedis.EmbeddedRedis
 import org.springframework.context.annotation.Bean
 import org.springframework.context.annotation.Configuration
 import redis.clients.jedis.Jedis
-import redis.clients.util.Pool
+import redis.clients.jedis.util.Pool
 
 @Configuration
 class EmbeddedRedisConfiguration {

diff --git a/gradle.properties b/gradle.properties
@@ -1,6 +1,6 @@
 #Tue Dec 10 20:06:06 UTC 2019
 fiatVersion=1.9.2
 enablePublishing=false
-korkVersion=6.22.2
+korkVersion=7.0.0
 spinnakerGradleVersion=7.0.1
 org.gradle.parallel=true