Skip to content

Commit

Permalink
chore(hipchat): remove Hipchat integration (#533)
Browse files Browse the repository at this point in the history
  • Loading branch information
anotherchrisberry committed May 15, 2019
1 parent d71c9d1 commit d175913
Show file tree
Hide file tree
Showing 8 changed files with 2 additions and 327 deletions.
3 changes: 2 additions & 1 deletion README.md
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,8 @@ It provides integrations for outgoing notifications in the echo-notifications pa

* email
* Slack
* Hipchat
* Bearychat
* Google Chat
* sms ( via Twilio )

Echo is also able to send events within Spinnaker to a predefined url, which is configurable under the echo-rest module.
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -38,7 +38,6 @@ class Notification {
EMAIL,
GITHUB_STATUS,
GOOGLECHAT,
HIPCHAT,
JIRA,
PAGER_DUTY,
PUBSUB,
Expand Down

This file was deleted.

This file was deleted.

This file was deleted.

This file was deleted.

This file was deleted.

Original file line number Diff line number Diff line change
Expand Up @@ -17,9 +17,6 @@
package com.netflix.spinnaker.echo.notification

import com.netflix.spinnaker.echo.api.Notification
import com.netflix.spinnaker.echo.hipchat.HipchatMessage
import com.netflix.spinnaker.echo.hipchat.HipchatNotificationService
import com.netflix.spinnaker.echo.hipchat.HipchatService
import com.netflix.spinnaker.echo.twilio.TwilioNotificationService
import com.netflix.spinnaker.echo.twilio.TwilioService
import org.springframework.boot.autoconfigure.freemarker.FreeMarkerNonWebConfiguration
Expand All @@ -42,30 +39,6 @@ class NotificationServiceSpec extends Specification {
)
}

void "should send specific hipchat message"() {
given:
def hipchatService = Mock(HipchatService)
def hipchatNotificationService = new HipchatNotificationService(
token: "token",
notificationTemplateEngine: notificationTemplateEngine,
hipchat: hipchatService
)
def notification = new Notification(
notificationType: "HIPCHAT",
templateGroup: "example",
to: ["room"],
source: new Notification.Source(application: "application")
)

when:
hipchatNotificationService.handle(notification)

then:
1 * hipchatService.sendMessage("token", "room", { HipchatMessage message ->
message.message == "specific SPINNAKER_URL application"
} as HipchatMessage)
}

void "should send generic twilio message"() {
given:
def twilioService = Mock(TwilioService)
Expand Down

0 comments on commit d175913

Please sign in to comment.