fix(misc): Remove OkHttp2 usage and use provider impls #1010
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jonsie
approved these changes
Sep 14, 2020
ajordens
approved these changes
Sep 14, 2020
robzienert
approved these changes
Sep 15, 2020
echo-rest/echo-rest.gradle
Outdated
| implementation "com.squareup.okhttp:okhttp" | ||
| implementation "com.squareup.okhttp:okhttp-urlconnection" | ||
| implementation "com.squareup.okhttp:okhttp-apache" | ||
| implementation "com.jakewharton.retrofit:retrofit1-okhttp3-client:1.1.0" |
There was a problem hiding this comment.
Seeing this dep leak into multiple PRs. Should be added to spinnaker-dependencies.
jonsie
approved these changes
Sep 21, 2020
srekapalli
force-pushed
the
ok2_cleanup
branch
from
6eb6406
to
92740ed
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Remove OkHttp2 usage.