fix(bitbucket): Log when Bitbucket event unknown #581
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There are rare cases (often when the /bitbucket endpoint is used instead of /stash) where the bitbucket event type doesn't match _either_ the Cloud or Server types; this can cause an NPE in the subsequent log message because "branch" doesn't get set (this was also fixed, although should probably not happen any more). In this case, we log the fact that we couldn't determine the Cloud/Server type based on the event_type (noting the event_type we _did_ get) and return.
staciegravy
approved these changes
Jun 19, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There are rare cases (often when the /bitbucket endpoint is used instead
of /stash) where the bitbucket event type doesn't match either the
Cloud or Server types; this can cause an NPE in the subsequent log
message because "branch" doesn't get set (this was also fixed, although
should probably not happen any more). In this case, we log the fact
that we couldn't determine the Cloud/Server type based on the event_type
(noting the event_type we did get) and return.