Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test(google): Enable the GoogleChatNotificationAgent test #650

Merged
merged 1 commit into from
Sep 10, 2019
Merged

test(google): Enable the GoogleChatNotificationAgent test #650

merged 1 commit into from
Sep 10, 2019

Conversation

plumpy
Copy link
Member

@plumpy plumpy commented Sep 10, 2019

It wasn't running because it didn't have extends Specification.

ezimanyi
ezimanyi approved these changes Sep 10, 2019
View reviewed changes
Copy link
Contributor

@ezimanyi ezimanyi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

1️⃣ 0️⃣ ^ 💯 💬

@plumpy plumpy merged commit ff2268c into spinnaker:master Sep 10, 2019
@plumpy plumpy deleted the enable_tests branch September 10, 2019 20:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ezimanyi ezimanyi ezimanyi approved these changes

Assignees
No one assigned
Labels
target-release/1.17
Projects
None yet
Milestone
No milestone
3 participants
@plumpy @ezimanyi @spinnakerbot