fix(triggers): Remove confusing/unnecessary error log #664
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
😆 LGTM! Thanks and sorry for the confusion. |
|
Thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
WHAT
This pull request removes confusing/unnecessary error log from
ManualEventHandler#resolveArtifacts.WHY
ref: feat(artifacts): populate artifacts for manual trigger
The error log was added in the commit:
1a6fb33#diff-3861ae251662b1f07aee9125cec36ad4R129
But the code was changed in the next commit in the pull request for existing behavior:
8c371ce#diff-3861ae251662b1f07aee9125cec36ad4R143
So the error log is unnecessary and confusing.
Actually I was confused with the error log while debugging 😁