feat(tasks): allow notifications for tasks #668
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
emjburns
force-pushed
the
tasks-send-notifications
branch
from
f870eb5
to
94e14c6
Compare
robzienert
reviewed
Oct 2, 2019
| if (config.type == 'stage') { | ||
| String stageName = event.content.name ?: event.content?.context?.stageDetails?.name | ||
| message = """Stage $stageName for """ | ||
| if (config.type == 'pipeline' || config.type == 'stage') { |
There was a problem hiding this comment.
Pulling on a thread here... I think we may want to isExecution(config.type) here as well. I bet the other notification agents also have similar conditions.
There was a problem hiding this comment.
how about I save those improvements for going through and cleaning up all the notification logic?
robfletcher
approved these changes
Oct 2, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Right now we can't send notifications for tasks. Why? Not sure. This code is 2015 vintage.
This PR adds support for sending notifications for tasks:
It also moves some error handling from subclasses to the parent class because of 💁style.