feat(extension): Add event parser extension for echo-rest #703
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jonsie
requested review from
cfieber,
marchello2000,
srekapalli and
dreynaud
cfieber
reviewed
Nov 20, 2019
jonsie
force-pushed
the
event-parser-extension
branch
from
856754d
to
ee7a9e4
Compare
jonsie
force-pushed
the
event-parser-extension
branch
2 times, most recently
from
f68edc3
to
5a6e5d5
Compare
cfieber
approved these changes
Nov 22, 2019
echo-api/src/main/java/com/netflix/spinnaker/echo/extension/rest/RestEventParser.java
Outdated
Show resolved
Hide resolved
echo-api/src/main/java/com/netflix/spinnaker/echo/extension/rest/RestEventParser.java
Outdated
Show resolved
Hide resolved
echo-api/src/main/java/com/netflix/spinnaker/echo/extension/rest/RestEventParser.java
Outdated
Show resolved
Hide resolved
echo-rest/src/main/groovy/com/netflix/spinnaker/echo/events/RestEventListener.groovy
Outdated
Show resolved
Hide resolved
jonsie
force-pushed
the
event-parser-extension
branch
from
5a6e5d5
to
1b64b2a
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Alpha PF4J extension for parsing Echo events prior to POST to configured service. This implementation is quite simple at the moment.
Current implementation will override any additional configuration (like
wrap). However, as this progresses I would like to see this extension point work with existing configurations and allow multiple parsers for multiple configured URLs.If things progress well, the more powerful extension point would be
EchoEventListenerwhich would allow us to decompose echo event listeners into discrete plugins.