Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(slack): Left-over fixes from interactive notifications #774

Merged
merged 5 commits into from
Feb 13, 2020

Conversation

luispollo
Copy link
Contributor

@luispollo luispollo commented Feb 12, 2020

Fixes the following:

  1. Fix and enable signature verification for Slack callbacks: turns out Spring was messing with the URL-encoded payload for some reason (or so it seems -- at least I couldn't find any other culprits on the path of the request processing). I was unable to find a matching issue against Spring although there were other problems reported with inconsistent URL encoding behavior.
  2. Left-over refactored method call that I missed to update before.

@luispollo luispollo self-assigned this Feb 12, 2020
@spinnakerbot
Copy link
Contributor

The following commits need their title changed:

  • c54a545: Remove token verification in favor of signature verification

Please format your commit title into the form:

<type>(<scope>): <subject>, e.g. fix(kubernetes): address NPE in status check

This allows us to easily generate changelogs & determine semantic version numbers when cutting releases. You can read more about commit conventions here.

@luispollo luispollo changed the title fix(slack): Fix and enable signature verification for Slack callbacks fix(slack): Left-over fixes from interactive notifications Feb 13, 2020
@luispollo luispollo merged commit a959f4f into spinnaker:master Feb 13, 2020
@luispollo luispollo deleted the interactive-slack branch February 13, 2020 03:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants