feat(roles): Add Execute as a type of Authorization

spinnaker · Apr 19, 2019 · 29adca8 · 29adca8
1 parent 6b10574
commit 29adca8
Show file tree

Hide file tree

Showing 4 changed files with 6 additions and 5 deletions.
diff --git a/fiat-core/src/main/java/com/netflix/spinnaker/fiat/model/Authorization.java b/fiat-core/src/main/java/com/netflix/spinnaker/fiat/model/Authorization.java
@@ -18,5 +18,6 @@
 
 public enum Authorization {
   READ,
-  WRITE
+  WRITE,
+  EXECUTE
 }
diff --git a/fiat-core/src/main/java/com/netflix/spinnaker/fiat/model/resources/Application.java b/fiat-core/src/main/java/com/netflix/spinnaker/fiat/model/resources/Application.java
@@ -49,7 +49,7 @@ public static class View extends BaseView implements Authorizable {
     public View(Application application, Set<Role> userRoles, boolean isAdmin) {
       this.name = application.name;
       if (isAdmin) {
-        this.authorizations = Sets.newHashSet(Authorization.READ, Authorization.WRITE);
+        this.authorizations = Sets.newHashSet(Authorization.READ, Authorization.WRITE, Authorization.EXECUTE);
       } else {
         this.authorizations = application.permissions.getAuthorizations(userRoles);
       }

diff --git a/fiat-core/src/main/java/com/netflix/spinnaker/fiat/model/resources/Permissions.java b/fiat-core/src/main/java/com/netflix/spinnaker/fiat/model/resources/Permissions.java
@@ -106,8 +106,7 @@ public Set<Authorization> getAuthorizations(List<String> userRoles) {
                .collect(Collectors.toSet());
   }
 
-  @VisibleForTesting
-  protected List<String> get(Authorization a) {
+  public List<String> get(Authorization a) {
     return permissions.get(a);
   }
 

diff --git a/fiat-core/src/test/groovy/com/netflix/spinnaker/fiat/model/resources/PermissionsSpec.groovy b/fiat-core/src/test/groovy/com/netflix/spinnaker/fiat/model/resources/PermissionsSpec.groovy
@@ -32,6 +32,7 @@ class PermissionsSpec extends Specification {
 
   private static final Authorization R = Authorization.READ
   private static final Authorization W = Authorization.WRITE
+  private static final Authorization E = Authorization.EXECUTE
 
   @Autowired
   TestConfigProps testConfigProps
@@ -149,7 +150,7 @@ class PermissionsSpec extends Specification {
     Permissions p = new Permissions.Builder().build()
 
     expect:
-    p.getAuthorizations([]) == [R, W] as Set
+    p.getAuthorizations([]) == [R, W, E] as Set
 
     when:
     p = Permissions.factory([(R): ["bar"], (W): ["bar"]])