Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(fiat): Suppress application details when updating permissions #1060

Merged

Conversation

kirangodishala
Copy link
Contributor

  • This PR allows skipping Application.details while caching the UserPermission.
  • This is an opt-in feature which can be enabled by the following configuration:
resource:
  provider:
    application:
      suppressDetails: true

@mattgogerly
Copy link
Member

Could you clarify what you mean by application.details? Do you have an example of a cache entry before and after this change?

@jvz
Copy link
Contributor

jvz commented Jun 7, 2023

This seems like an interesting idea, though I wonder why we even cache things besides permissions in that table in the first place?

@kirangodishala
Copy link
Contributor Author

kirangodishala commented Jun 7, 2023

Could you clarify what you mean by application.details? Do you have an example of a cache entry before and after this change?

@mattgogerly - when fiat fetches applications from Front50(also from clouddriver) these details come along.
image

@kirangodishala
Copy link
Contributor Author

kirangodishala commented Jun 7, 2023

This seems like an interesting idea, though I wonder why we even cache things besides permissions in that table in the first place?

@jvz - as mentioned above, Application data primarily comes from Front50 (/v2/applications?restricted=false) and gets parsed into Application object and the additional details were never removed.

@dbyron-sf dbyron-sf added the ready to merge Approved and ready for merge label Jun 9, 2023
@mergify mergify bot added the auto merged label Jun 9, 2023
@mergify mergify bot merged commit 66a6483 into spinnaker:master Jun 9, 2023
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
5 participants