fix(ldap): Disable LDAP health indicator #405
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There is currently an NPE in the LDAP health indicator that has been fixed but not yet released which is causing fiat to never appear healthy. Until we can pull in the upstream fix, disable the LDAP health indicator.
dibyom
approved these changes
May 8, 2019
|
This should only disable the health check (which is currently broken anyway), so the effect would be that fiat would still show healthy even if the downstream LDAP is down. |
clanesf
pushed a commit
to clanesf/fiat
that referenced
this pull request
Jul 12, 2019
There is currently an NPE in the LDAP health indicator that has been fixed but not yet released which is causing fiat to never appear healthy. Until we can pull in the upstream fix, disable the LDAP health indicator.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes spinnaker/spinnaker#4346. When we discussed a couple of weeks ago, I didn't realize there was a way to turn of the health indicator from the code (rather than from config). Given it's possible to do that, it's probably easier to do this and then revert it once we pull in the upstream fix.
There is currently an NPE in the LDAP health indicator that has been fixed but not yet released which is causing fiat to never appear healthy. Until we can pull in the upstream fix, disable the LDAP health indicator.