Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(error): Improve access denied error messaging #474

Merged

Conversation

jonsie
Copy link
Collaborator

@jonsie jonsie commented Sep 25, 2019

This is the first part of the change to improve front50's access denied error messaging. After this change we will replace front50's AccessDeniedExceptionHandler with FiatAccessDeniedExceptionHandler.

Here are examples of the different error message contexts:

//Non service account example:
{
  "timestamp": "2019-09-25T18:41:21.833+0000",
  "status": 403,
  "error": "Forbidden",
  "message": "Access denied to application smalleytest - required authorization: WRITE"
}

//Service account example:
{
  "timestamp": "2019-09-25T18:44:27.137+0000",
  "status": 403,
  "error": "Forbidden",
  "message": "Access denied to serviceaccount someServiceAccount"
}

@jonsie jonsie force-pushed the improve-access-denied-error-messaging branch 3 times, most recently from ab95141 to 0857670 Compare September 25, 2019 23:12
@jonsie jonsie force-pushed the improve-access-denied-error-messaging branch from 0857670 to 6e30483 Compare September 25, 2019 23:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants