fix(serviceAccount): Filter non-valid roles when converting to UserPermission (#513) #514
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…rmission (#513) Roles can't be empty. This leads to unexpected behaviour. However, we were allowing creating empty roles like "" or " " on the pipeline triggersi (via API), which made service users to contain invalid roles and thus failing on every sync request that tries to map roles to accounts. This rendered FIAT unusable to get permissions and subsequently not allowing any authorization operation. This patch sanitizes the input on ServiceAccounts so we make sure that the roles considered are valid.
ttomsu
deleted the
auto-cherry-pick-1.17-2bf147213285434f64f7b973e316b5127dd5b6e0
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Roles can't be empty. This leads to unexpected behaviour. However, we
were allowing creating empty roles like "" or " " on the pipeline
triggersi (via API), which made service users to contain invalid roles
and thus failing on every sync request that tries to map roles to accounts.
This rendered FIAT unusable to get permissions and subsequently not
allowing any authorization operation.
This patch sanitizes the input on ServiceAccounts so we make sure
that the roles considered are valid.