Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(errors): Import kork-web ErrorConfiguration into fiat-api configuration, wire up FiatAccessDeniedExceptionHandler #785

Merged

Conversation

jonsie
Copy link
Collaborator

@jonsie jonsie commented Sep 25, 2020

No description provided.

…ration, wire up FiatAccessDeniedExceptionHandler
@@ -83,6 +90,13 @@ FiatWebSecurityConfigurerAdapter fiatSecurityConfig(FiatStatus fiatStatus) {
return new FiatWebSecurityConfigurerAdapter(fiatStatus);
}

@Bean
@Order(HIGHEST_PRECEDENCE)
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This will ensure FiatAccessDeniedExceptionHandler always handles access denied errors since kork-web's GenericExceptionHandlers is also wired up.

Copy link
Contributor

@cfieber cfieber left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@jonsie jonsie merged commit f2bc5c6 into spinnaker:master Sep 25, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants