chore(ci): GHA - simplify build versioning #927
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kskewes-sf
force-pushed
the
gha-build-ver
branch
from
7379be3
to
d42f6d4
Compare
- collapse version info gathering steps into single `build_variables` step - collapse version info parts into single string and use everywhere. - use short git sha: `(git rev-parse --short HEAD)` Note `build.yml` versioning is not compatible with Debian package building as gradle plugin enforces `^[0-9]+`. We don't publish master branch or release-* branches to GAR apt repository though. Prefixing the version with `<tag>-dev-` or something and publishing Debian packages is possible but may pollute `apt-cache policy spinnaker-rosco` output and overall be unnecessary with regular releases.
kskewes-sf
force-pushed
the
gha-build-ver
branch
from
d42f6d4
to
893a63e
Compare
dbyron-sf
approved these changes
Mar 16, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
build_variablesstep(git rev-parse --short HEAD)Note
build.ymlversioning is not compatible with Debian packagebuilding as gradle plugin enforces
^[0-9]+.We don't publish master branch or release-* branches to GAR apt
repository though.
Prefixing the version with
<tag>-dev-or something and publishing Debianpackages is possible but may pollute
apt-cache policy spinnaker-roscooutputand overall be unnecessary with regular releases.