fix(google): skip groups for service accounts

[perek]

Currently the google roles provider checks Google Groups for all service accounts, this is impossible to succeed because these are not real domains usable in Google Groups. This causes a couple of issues around rate limiting due to bad requests, and artificially increases the load on the Admin Directory API quota. By skipping over this without hitting Google we reduce the time needed to check permissions for this, and improve stability of this API

[ttomsu]

Hello, darkness, my old friend...

I'm not apart of this project anymore.

[perek]

We will never forget you @ttomsu

[perek]

[perek]

@dbyron-sf can you review this?

[dbyron-sf]

Sorry @perek , I'm not familiar with this code.

[link108]

@perek this looks reasonable to me, thanks for adding tests as well 👍 I'm not super knowledgable re: google groups and service accounts, but it looks like they may have added the ability to use service accounts in groups: https://workspaceupdates.googleblog.com/2020/08/service-accounts-in-google-groups-beta.html

[perek]

@perek this looks reasonable to me, thanks for adding tests as well 👍 I'm not super knowledgable re: google groups and service accounts, but it looks like they may have added the ability to use service accounts in groups: https://workspaceupdates.googleblog.com/2020/08/service-accounts-in-google-groups-beta.html

Yes, but that is not a spinnaker service account. Spinnaker service account don’t even have a domain, impossible to use on google

[link108]

SGTM 👍