fix(exceptions): Use kork's NotFoundException (#922)

Follow up from spinnaker/kork#737 where I added a generic 400 response exception handler for UserException.
But `front50` needs to return an actual 404 (since callers, e.g. `orca` expect and handle it).
Kork already has a generic 404 handler for NotFoundException

front50-azure/src/main/java/com/netflix/spinnaker/front50/model/AzureStorageService.java

@@ -24,7 +24,7 @@
 import com.microsoft.azure.storage.ResultSegment;
 import com.microsoft.azure.storage.StorageException;
 import com.microsoft.azure.storage.blob.*;
-import com.netflix.spinnaker.front50.exception.NotFoundException;
+import com.netflix.spinnaker.kork.web.exceptions.NotFoundException;
 import com.netflix.spinnaker.security.AuthenticatedRequest;
 import java.io.IOException;
 import java.net.HttpURLConnection;

front50-core/src/main/java/com/netflix/spinnaker/front50/ApplicationPermissionsService.java

@@ -21,11 +21,11 @@
 import com.netflix.spinnaker.front50.config.FiatConfigurationProperties;
 import com.netflix.spinnaker.front50.events.ApplicationPermissionEventListener;
 import com.netflix.spinnaker.front50.events.ApplicationPermissionEventListener.Type;
-import com.netflix.spinnaker.front50.exception.NotFoundException;
 import com.netflix.spinnaker.front50.model.application.Application.Permission;
 import com.netflix.spinnaker.front50.model.application.ApplicationDAO;
 import com.netflix.spinnaker.front50.model.application.ApplicationPermissionDAO;
 import com.netflix.spinnaker.kork.exceptions.SystemException;
+import com.netflix.spinnaker.kork.web.exceptions.NotFoundException;
 import java.util.AbstractMap.SimpleEntry;
 import java.util.ArrayList;
 import java.util.Collection;

front50-core/src/main/java/com/netflix/spinnaker/front50/ServiceAccountsService.java

@@ -21,9 +21,9 @@
 import com.netflix.spinnaker.fiat.shared.FiatService;
 import com.netflix.spinnaker.front50.config.FiatConfigurationProperties;
 import com.netflix.spinnaker.front50.config.annotations.ConditionalOnAnyProviderExceptRedisIsEnabled;
-import com.netflix.spinnaker.front50.exception.NotFoundException;
 import com.netflix.spinnaker.front50.model.serviceaccount.ServiceAccount;
 import com.netflix.spinnaker.front50.model.serviceaccount.ServiceAccountDAO;
+import com.netflix.spinnaker.kork.web.exceptions.NotFoundException;
 import java.util.Collection;
 import java.util.Collections;
 import java.util.List;

front50-core/src/main/java/com/netflix/spinnaker/front50/model/ItemDAO.java

@@ -1,6 +1,6 @@
 package com.netflix.spinnaker.front50.model;
 
-import com.netflix.spinnaker.front50.exception.NotFoundException;
+import com.netflix.spinnaker.kork.web.exceptions.NotFoundException;
 import java.time.Duration;
 import java.util.Collection;
 

front50-core/src/main/java/com/netflix/spinnaker/front50/model/StorageService.java

@@ -16,7 +16,7 @@
 
 package com.netflix.spinnaker.front50.model;
 
-import com.netflix.spinnaker.front50.exception.NotFoundException;
+import com.netflix.spinnaker.kork.web.exceptions.NotFoundException;
 import java.time.Duration;
 import java.util.Collection;
 import java.util.List;

front50-core/src/main/java/com/netflix/spinnaker/front50/model/StorageServiceSupport.java

@@ -21,7 +21,7 @@
 import com.netflix.spectator.api.Counter;
 import com.netflix.spectator.api.Registry;
 import com.netflix.spectator.api.Timer;
-import com.netflix.spinnaker.front50.exception.NotFoundException;
+import com.netflix.spinnaker.kork.web.exceptions.NotFoundException;
 import com.netflix.spinnaker.security.AuthenticatedRequest;
 import com.netflix.spinnaker.security.User;
 import io.github.resilience4j.circuitbreaker.CircuitBreaker;

front50-core/src/main/java/com/netflix/spinnaker/front50/model/application/ApplicationDAO.java

@@ -18,9 +18,9 @@
 
 import com.google.common.base.Strings;
 import com.netflix.spinnaker.front50.UntypedUtils;
-import com.netflix.spinnaker.front50.exception.NotFoundException;
 import com.netflix.spinnaker.front50.model.ItemDAO;
 import com.netflix.spinnaker.front50.model.SearchUtils;
+import com.netflix.spinnaker.kork.web.exceptions.NotFoundException;
 import java.util.*;
 import java.util.stream.Collectors;
 

front50-core/src/main/java/com/netflix/spinnaker/front50/model/application/ApplicationService.java

@@ -22,7 +22,6 @@
 import com.netflix.spinnaker.front50.ServiceAccountsService;
 import com.netflix.spinnaker.front50.events.ApplicationEventListener;
 import com.netflix.spinnaker.front50.events.ApplicationEventListener.ApplicationModelEvent;
-import com.netflix.spinnaker.front50.exception.NotFoundException;
 import com.netflix.spinnaker.front50.exception.ValidationException;
 import com.netflix.spinnaker.front50.model.notification.HierarchicalLevel;
 import com.netflix.spinnaker.front50.model.notification.NotificationDAO;
@@ -33,6 +32,7 @@
 import com.netflix.spinnaker.front50.validator.ApplicationValidationErrors;
 import com.netflix.spinnaker.front50.validator.ApplicationValidator;
 import com.netflix.spinnaker.kork.annotations.NonnullByDefault;
+import com.netflix.spinnaker.kork.web.exceptions.NotFoundException;
 import java.util.*;
 import java.util.stream.Collectors;
 import javax.annotation.Nullable;

front50-core/src/main/java/com/netflix/spinnaker/front50/model/application/DefaultApplicationDAO.java

@@ -17,11 +17,11 @@
 package com.netflix.spinnaker.front50.model.application;
 
 import com.netflix.spectator.api.Registry;
-import com.netflix.spinnaker.front50.exception.NotFoundException;
 import com.netflix.spinnaker.front50.model.ObjectKeyLoader;
 import com.netflix.spinnaker.front50.model.ObjectType;
 import com.netflix.spinnaker.front50.model.StorageService;
 import com.netflix.spinnaker.front50.model.StorageServiceSupport;
+import com.netflix.spinnaker.kork.web.exceptions.NotFoundException;
 import io.github.resilience4j.circuitbreaker.CircuitBreakerRegistry;
 import java.util.Collection;
 import java.util.Map;

front50-core/src/main/java/com/netflix/spinnaker/front50/model/notification/DefaultNotificationDAO.java

@@ -17,11 +17,11 @@
 package com.netflix.spinnaker.front50.model.notification;
 
 import com.netflix.spectator.api.Registry;
-import com.netflix.spinnaker.front50.exception.NotFoundException;
 import com.netflix.spinnaker.front50.model.ObjectKeyLoader;
 import com.netflix.spinnaker.front50.model.ObjectType;
 import com.netflix.spinnaker.front50.model.StorageService;
 import com.netflix.spinnaker.front50.model.StorageServiceSupport;
+import com.netflix.spinnaker.kork.web.exceptions.NotFoundException;
 import io.github.resilience4j.circuitbreaker.CircuitBreakerRegistry;
 import rx.Scheduler;
 

front50-core/src/main/java/com/netflix/spinnaker/front50/model/pipeline/DefaultPipelineDAO.java

@@ -17,11 +17,11 @@
 package com.netflix.spinnaker.front50.model.pipeline;
 
 import com.netflix.spectator.api.Registry;
-import com.netflix.spinnaker.front50.exception.NotFoundException;
 import com.netflix.spinnaker.front50.model.ObjectKeyLoader;
 import com.netflix.spinnaker.front50.model.ObjectType;
 import com.netflix.spinnaker.front50.model.StorageService;
 import com.netflix.spinnaker.front50.model.StorageServiceSupport;
+import com.netflix.spinnaker.kork.web.exceptions.NotFoundException;
 import io.github.resilience4j.circuitbreaker.CircuitBreakerRegistry;
 import java.util.Collection;
 import java.util.UUID;

front50-core/src/main/java/com/netflix/spinnaker/front50/model/pipeline/DefaultPipelineStrategyDAO.java

@@ -17,11 +17,11 @@
 package com.netflix.spinnaker.front50.model.pipeline;
 
 import com.netflix.spectator.api.Registry;
-import com.netflix.spinnaker.front50.exception.NotFoundException;
 import com.netflix.spinnaker.front50.model.ObjectKeyLoader;
 import com.netflix.spinnaker.front50.model.ObjectType;
 import com.netflix.spinnaker.front50.model.StorageService;
 import com.netflix.spinnaker.front50.model.StorageServiceSupport;
+import com.netflix.spinnaker.kork.web.exceptions.NotFoundException;
 import io.github.resilience4j.circuitbreaker.CircuitBreakerRegistry;
 import java.util.Collection;
 import java.util.UUID;

front50-core/src/main/java/com/netflix/spinnaker/front50/model/plugins/PluginInfoService.java

@@ -17,12 +17,12 @@
 
 import com.netflix.spinnaker.front50.config.annotations.ConditionalOnAnyProviderExceptRedisIsEnabled;
 import com.netflix.spinnaker.front50.echo.EchoService;
-import com.netflix.spinnaker.front50.exception.NotFoundException;
 import com.netflix.spinnaker.front50.plugins.PluginBinaryStorageService;
 import com.netflix.spinnaker.front50.validator.GenericValidationErrors;
 import com.netflix.spinnaker.front50.validator.PluginInfoValidator;
 import com.netflix.spinnaker.kork.exceptions.UserException;
 import com.netflix.spinnaker.kork.web.exceptions.InvalidRequestException;
+import com.netflix.spinnaker.kork.web.exceptions.NotFoundException;
 import com.netflix.spinnaker.security.AuthenticatedRequest;
 import java.time.Instant;
 import java.util.ArrayList;

front50-core/src/main/java/com/netflix/spinnaker/front50/model/plugins/PluginVersionPinningService.java

@@ -17,7 +17,7 @@
 
 import static java.lang.String.format;
 
-import com.netflix.spinnaker.front50.exception.NotFoundException;
+import com.netflix.spinnaker.kork.web.exceptions.NotFoundException;
 import java.util.HashMap;
 import java.util.Map;
 import org.slf4j.Logger;

front50-core/src/main/java/com/netflix/spinnaker/front50/model/project/DefaultProjectDAO.java

@@ -17,11 +17,11 @@
 package com.netflix.spinnaker.front50.model.project;
 
 import com.netflix.spectator.api.Registry;
-import com.netflix.spinnaker.front50.exception.NotFoundException;
 import com.netflix.spinnaker.front50.model.ObjectKeyLoader;
 import com.netflix.spinnaker.front50.model.ObjectType;
 import com.netflix.spinnaker.front50.model.StorageService;
 import com.netflix.spinnaker.front50.model.StorageServiceSupport;
+import com.netflix.spinnaker.kork.web.exceptions.NotFoundException;
 import io.github.resilience4j.circuitbreaker.CircuitBreakerRegistry;
 import java.util.UUID;
 import rx.Scheduler;

front50-core/src/main/java/com/netflix/spinnaker/front50/model/project/ProjectDAO.java

@@ -1,7 +1,7 @@
 package com.netflix.spinnaker.front50.model.project;
 
-import com.netflix.spinnaker.front50.exception.NotFoundException;
 import com.netflix.spinnaker.front50.model.ItemDAO;
+import com.netflix.spinnaker.kork.web.exceptions.NotFoundException;
 import java.util.Collection;
 
 public interface ProjectDAO extends ItemDAO<Project> {

front50-core/src/test/groovy/com/netflix/spinnaker/front50/ServiceAccountsServiceSpec.groovy

@@ -20,7 +20,7 @@ import com.netflix.spinnaker.fiat.shared.FiatClientConfigurationProperties
 import com.netflix.spinnaker.fiat.shared.FiatPermissionEvaluator
 import com.netflix.spinnaker.fiat.shared.FiatService
 import com.netflix.spinnaker.front50.config.FiatConfigurationProperties
-import com.netflix.spinnaker.front50.exception.NotFoundException
+import com.netflix.spinnaker.kork.web.exceptions.NotFoundException
 import com.netflix.spinnaker.front50.model.serviceaccount.ServiceAccount
 import com.netflix.spinnaker.front50.model.serviceaccount.ServiceAccountDAO
 import org.springframework.security.core.Authentication

front50-core/src/test/groovy/com/netflix/spinnaker/front50/model/application/ApplicationServiceSpec.groovy

@@ -19,7 +19,7 @@ package com.netflix.spinnaker.front50.model.application
 
 import com.netflix.spinnaker.front50.ServiceAccountsService
 import com.netflix.spinnaker.front50.events.ApplicationEventListener
-import com.netflix.spinnaker.front50.exception.NotFoundException
+import com.netflix.spinnaker.kork.web.exceptions.NotFoundException
 import com.netflix.spinnaker.front50.exception.ValidationException
 import com.netflix.spinnaker.front50.model.notification.HierarchicalLevel
 import com.netflix.spinnaker.front50.model.notification.NotificationDAO

front50-core/src/test/groovy/com/netflix/spinnaker/front50/model/plugins/PluginInfoServiceSpec.groovy

@@ -16,7 +16,7 @@
 package com.netflix.spinnaker.front50.model.plugins
 
 import com.netflix.spinnaker.front50.echo.EchoService
-import com.netflix.spinnaker.front50.exception.NotFoundException
+import com.netflix.spinnaker.kork.web.exceptions.NotFoundException
 import com.netflix.spinnaker.front50.model.plugins.remote.RemoteExtension
 import com.netflix.spinnaker.front50.model.plugins.remote.stage.StageRemoteExtensionConfig
 import com.netflix.spinnaker.front50.plugins.PluginBinaryStorageService

front50-core/src/test/groovy/com/netflix/spinnaker/front50/model/plugins/PluginVersionPinningServiceSpec.groovy

@@ -16,7 +16,7 @@
 
 package com.netflix.spinnaker.front50.model.plugins
 
-import com.netflix.spinnaker.front50.exception.NotFoundException
+import com.netflix.spinnaker.kork.web.exceptions.NotFoundException
 import spock.lang.Specification
 import spock.lang.Subject
 

front50-gcs/src/main/kotlin/com/netflix/spinnaker/front50/model/GcsStorageService.kt

@@ -29,7 +29,7 @@ import com.google.cloud.storage.Storage.BucketGetOption
 import com.google.cloud.storage.StorageException
 import com.google.common.collect.ImmutableMap
 import com.google.common.util.concurrent.Futures
-import com.netflix.spinnaker.front50.exception.NotFoundException
+import com.netflix.spinnaker.kork.web.exceptions.NotFoundException
 import java.io.IOException
 import java.time.Duration
 import java.util.concurrent.ExecutorService

front50-gcs/src/test/kotlin/com/netflix/spinnaker/front50/model/TestGcsStorageService.kt

@@ -25,12 +25,12 @@ import com.google.cloud.storage.BucketInfo
 import com.google.cloud.storage.Storage
 import com.google.cloud.storage.StorageOptions
 import com.google.common.util.concurrent.MoreExecutors
-import com.netflix.spinnaker.front50.exception.NotFoundException
 import com.netflix.spinnaker.front50.model.GcsStorageService
 import com.netflix.spinnaker.front50.model.ObjectType
 import com.netflix.spinnaker.front50.model.application.Application
 import com.netflix.spinnaker.front50.model.delivery.Delivery
 import com.netflix.spinnaker.front50.model.pipeline.Pipeline
+import com.netflix.spinnaker.kork.web.exceptions.NotFoundException
 import io.mockk.every
 import io.mockk.mockk
 import io.mockk.slot

front50-oracle/src/main/java/com/netflix/spinnaker/front50/model/OracleStorageService.java

@@ -13,7 +13,7 @@
 import com.fasterxml.jackson.databind.ser.impl.SimpleFilterProvider;
 import com.google.common.base.Supplier;
 import com.netflix.spinnaker.front50.config.OracleProperties;
-import com.netflix.spinnaker.front50.exception.NotFoundException;
+import com.netflix.spinnaker.kork.web.exceptions.NotFoundException;
 import com.oracle.bmc.auth.AuthenticationDetailsProvider;
 import com.oracle.bmc.auth.SimpleAuthenticationDetailsProvider;
 import com.oracle.bmc.auth.SimplePrivateKeySupplier;

front50-redis/src/main/groovy/com/netflix/spinnaker/front50/redis/RedisApplicationDAO.groovy

@@ -16,7 +16,7 @@
 
 package com.netflix.spinnaker.front50.redis
 
-import com.netflix.spinnaker.front50.exception.NotFoundException
+import com.netflix.spinnaker.kork.web.exceptions.NotFoundException
 import com.netflix.spinnaker.front50.model.application.Application
 import com.netflix.spinnaker.front50.model.application.ApplicationDAO
 import org.springframework.data.redis.core.Cursor

front50-redis/src/main/groovy/com/netflix/spinnaker/front50/redis/RedisPipelineDAO.groovy

@@ -15,7 +15,7 @@
  */
 
 package com.netflix.spinnaker.front50.redis
-import com.netflix.spinnaker.front50.exception.NotFoundException
+import com.netflix.spinnaker.kork.web.exceptions.NotFoundException
 import com.netflix.spinnaker.front50.model.pipeline.Pipeline
 import com.netflix.spinnaker.front50.model.pipeline.PipelineDAO
 import org.springframework.data.redis.core.Cursor

front50-redis/src/main/groovy/com/netflix/spinnaker/front50/redis/RedisPipelineStrategyDAO.groovy

@@ -16,7 +16,7 @@
 
 package com.netflix.spinnaker.front50.redis
 
-import com.netflix.spinnaker.front50.exception.NotFoundException
+import com.netflix.spinnaker.kork.web.exceptions.NotFoundException
 import com.netflix.spinnaker.front50.model.pipeline.Pipeline
 import com.netflix.spinnaker.front50.model.pipeline.PipelineStrategyDAO
 import org.springframework.data.redis.core.Cursor

front50-redis/src/main/groovy/com/netflix/spinnaker/front50/redis/RedisPipelineTemplateDAO.java

@@ -16,9 +16,9 @@
 package com.netflix.spinnaker.front50.redis;
 
 import com.google.common.collect.Lists;
-import com.netflix.spinnaker.front50.exception.NotFoundException;
 import com.netflix.spinnaker.front50.model.pipeline.PipelineTemplate;
 import com.netflix.spinnaker.front50.model.pipeline.PipelineTemplateDAO;
+import com.netflix.spinnaker.kork.web.exceptions.NotFoundException;
 import java.io.IOException;
 import java.util.Collection;
 import java.util.Map;

front50-redis/src/main/groovy/com/netflix/spinnaker/front50/redis/RedisProjectDAO.groovy

@@ -16,7 +16,7 @@
 
 package com.netflix.spinnaker.front50.redis
 
-import com.netflix.spinnaker.front50.exception.NotFoundException
+import com.netflix.spinnaker.kork.web.exceptions.NotFoundException
 import com.netflix.spinnaker.front50.model.project.Project
 import com.netflix.spinnaker.front50.model.project.ProjectDAO
 import org.springframework.data.redis.core.Cursor

front50-redis/src/test/groovy/com/netflix/spinnaker/front50/redis/RedisApplicationDAOSpec.groovy

@@ -16,7 +16,7 @@
 
 package com.netflix.spinnaker.front50.redis
 
-import com.netflix.spinnaker.front50.exception.NotFoundException
+import com.netflix.spinnaker.kork.web.exceptions.NotFoundException
 import com.netflix.spinnaker.front50.model.application.Application
 import com.netflix.spinnaker.front50.redis.config.EmbeddedRedisConfig
 import org.springframework.beans.factory.annotation.Autowired

front50-redis/src/test/groovy/com/netflix/spinnaker/front50/redis/RedisPipelineDAOSpec.groovy

@@ -16,7 +16,7 @@
 
 package com.netflix.spinnaker.front50.redis
 
-import com.netflix.spinnaker.front50.exception.NotFoundException
+import com.netflix.spinnaker.kork.web.exceptions.NotFoundException
 import com.netflix.spinnaker.front50.model.pipeline.Pipeline
 import com.netflix.spinnaker.front50.pipeline.PipelineDAOSpec
 import com.netflix.spinnaker.front50.redis.config.EmbeddedRedisConfig

front50-redis/src/test/groovy/com/netflix/spinnaker/front50/redis/RedisPipelineStrategyDAOSpec.groovy

@@ -16,7 +16,7 @@
 
 package com.netflix.spinnaker.front50.redis
 
-import com.netflix.spinnaker.front50.exception.NotFoundException
+import com.netflix.spinnaker.kork.web.exceptions.NotFoundException
 import com.netflix.spinnaker.front50.model.pipeline.Pipeline
 import com.netflix.spinnaker.front50.redis.config.EmbeddedRedisConfig
 import org.springframework.beans.factory.annotation.Autowired

front50-redis/src/test/groovy/com/netflix/spinnaker/front50/redis/RedisProjectDAOSpec.groovy

@@ -16,7 +16,7 @@
 
 package com.netflix.spinnaker.front50.redis
 
-import com.netflix.spinnaker.front50.exception.NotFoundException
+import com.netflix.spinnaker.kork.web.exceptions.NotFoundException
 import com.netflix.spinnaker.front50.model.project.Project
 import com.netflix.spinnaker.front50.redis.config.EmbeddedRedisConfig
 import org.springframework.beans.factory.annotation.Autowired

front50-s3/src/main/java/com/netflix/spinnaker/front50/model/S3StorageService.java

@@ -25,7 +25,7 @@
 import com.fasterxml.jackson.core.JsonProcessingException;
 import com.fasterxml.jackson.databind.ObjectMapper;
 import com.google.common.collect.Lists;
-import com.netflix.spinnaker.front50.exception.NotFoundException;
+import com.netflix.spinnaker.kork.web.exceptions.NotFoundException;
 import java.io.ByteArrayInputStream;
 import java.io.IOException;
 import java.time.Duration;

front50-sql/src/main/kotlin/com/netflix/spinnaker/front50/model/CompositeStorageService.kt

@@ -17,8 +17,8 @@
 package com.netflix.spinnaker.front50.model
 
 import com.netflix.spectator.api.Registry
-import com.netflix.spinnaker.front50.exception.NotFoundException
 import com.netflix.spinnaker.kork.dynamicconfig.DynamicConfigService
+import com.netflix.spinnaker.kork.web.exceptions.NotFoundException
 import org.slf4j.LoggerFactory
 import org.springframework.scheduling.annotation.Scheduled
 

front50-sql/src/main/kotlin/com/netflix/spinnaker/front50/model/SqlStorageService.kt

@@ -18,7 +18,6 @@ package com.netflix.spinnaker.front50.model
 
 import com.fasterxml.jackson.databind.ObjectMapper
 import com.netflix.spectator.api.Registry
-import com.netflix.spinnaker.front50.exception.NotFoundException
 import com.netflix.spinnaker.front50.model.ObjectType.APPLICATION
 import com.netflix.spinnaker.front50.model.ObjectType.APPLICATION_PERMISSION
 import com.netflix.spinnaker.front50.model.ObjectType.DELIVERY
@@ -41,6 +40,7 @@ import com.netflix.spinnaker.front50.model.sql.transactional
 import com.netflix.spinnaker.front50.model.sql.withRetry
 import com.netflix.spinnaker.kork.sql.config.SqlRetryProperties
 import com.netflix.spinnaker.kork.sql.routing.withPool
+import com.netflix.spinnaker.kork.web.exceptions.NotFoundException
 import com.netflix.spinnaker.security.AuthenticatedRequest
 import java.time.Clock
 import kotlin.system.measureTimeMillis

front50-sql/src/test/kotlin/com/netflix/spinnaker/front50/model/CompositeStorageServiceTests.kt

@@ -17,10 +17,10 @@
 package com.netflix.spinnaker.front50.model
 
 import com.netflix.spectator.api.NoopRegistry
-import com.netflix.spinnaker.front50.exception.NotFoundException
 import com.netflix.spinnaker.front50.model.application.Application
 import com.netflix.spinnaker.front50.model.tag.EntityTags
 import com.netflix.spinnaker.kork.dynamicconfig.DynamicConfigService
+import com.netflix.spinnaker.kork.web.exceptions.NotFoundException
 import dev.minutest.junit.JUnit5Minutests
 import dev.minutest.rootContext
 import io.mockk.Called