Revert "feat(sql): CRUD Tests for SqlStorageService"

This reverts commit 6724d0f6c779ebc50fc50b2985b8265487c456e1.

front50-sql/front50-sql.gradle

@@ -1,22 +1,17 @@
 apply from: "$rootDir/gradle/kotlin.gradle"
 
 dependencies {
+  implementation "org.jetbrains.kotlinx:kotlinx-coroutines-core:1.2.1"
+  implementation "org.jetbrains.kotlinx:kotlinx-coroutines-core-common:1.2.1"
+  implementation "org.jetbrains.kotlinx:kotlinx-coroutines-slf4j:1.2.1"
+
   implementation "com.netflix.spinnaker.front50:front50-core:${front50Version}"
 
-  implementation "com.netflix.spinnaker.kork:kork-sql"
   implementation "com.netflix.spinnaker.kork:kork-exceptions"
-
-  implementation "org.jooq:jooq:3.11.11"
-  implementation "io.strikt:strikt-core" 
-  implementation "com.netflix.hystrix:hystrix-core"
+  implementation "com.netflix.spinnaker.kork:kork-sql"
   implementation "io.github.resilience4j:resilience4j-retry"
-  implementation "org.jetbrains.kotlinx:kotlinx-coroutines-core:1.2.1"
-  implementation "org.jetbrains.kotlinx:kotlinx-coroutines-slf4j:1.2.1"
-  implementation "org.jetbrains.kotlinx:kotlinx-coroutines-core-common:1.2.1"
 
-  runtimeOnly "mysql:mysql-connector-java"
+  runtime "mysql:mysql-connector-java:8.0.12"
 
-  testImplementation "dev.minutest:minutest"
-  testImplementation "org.testcontainers:mysql"
   testImplementation "com.netflix.spinnaker.kork:kork-sql-test"
 }

front50-sql/src/main/kotlin/com/netflix/spinnaker/front50/model/SqlStorageService.kt

@@ -18,7 +18,6 @@ package com.netflix.spinnaker.front50.model
 
 import com.fasterxml.jackson.databind.ObjectMapper
 import com.netflix.spectator.api.Registry
-import com.netflix.spinnaker.front50.exception.NotFoundException
 import com.netflix.spinnaker.security.AuthenticatedRequest
 import org.jooq.DSLContext
 import org.jooq.impl.DSL
@@ -72,7 +71,7 @@ class SqlStorageService(
         .from(definitionsByType[objectType]!!.tableName)
         .where(field("id", String::class.java).eq(objectKey))
         .fetchOne()
-    } ?: throw NotFoundException("Object not found (key: $objectKey)")
+    }
 
     return objectMapper.readValue(result.get(field("body", String::class.java)), objectType.clazz as Class<T>)
   }
@@ -138,7 +137,6 @@ class SqlStorageService(
   }
 
   override fun listObjectKeys(objectType: ObjectType): Map<String, Long> {
-    val startTime = System.currentTimeMillis()
     val resultSet = jooq.withRetry(sqlRetryProperties.reads) { ctx ->
       ctx
         .select(
@@ -157,12 +155,6 @@ class SqlStorageService(
       objectKeys.put(resultSet.getString(1), resultSet.getLong(2))
     }
 
-    log.debug("Took {}ms to fetch {} object keys for {}",
-      System.currentTimeMillis() - startTime,
-      objectKeys.size,
-      objectType
-    )
-
     return objectKeys
   }