Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(provider/azure): Stop making containers public #1018

Merged
merged 1 commit into from
Aug 24, 2021

Conversation

pedrohdz
Copy link
Contributor

@pedrohdz
Copy link
Contributor Author

@jasonmcintosh, Ready to go.

@pedrohdz
Copy link
Contributor Author

pedrohdz commented May 29, 2021

@spinnaker/reviewers

Ahoy!
Could someone please take a look? Let me know if there is something I need to follow up on.

Thanks!

@pedrohdz pedrohdz closed this May 29, 2021
@pedrohdz pedrohdz reopened this May 29, 2021
@pedrohdz pedrohdz changed the title fix(provider/azure): SECURITY VULNERABILITY, stop making containers public fix(provider/azure): Stop making containers public Jun 1, 2021
@jkschneider
Copy link
Member

@pedrohdz I'm watching this now. Could you please rebase one more time and we can get this merged?

…ublic

This is an attempt to fix:

- spinnaker/spinnaker#5892
- spinnaker/spinnaker#6218

The following PRs attempted to address this issue, and appear to be
orphaned:

- spinnaker#900 - Failing checks.
- spinnaker#1002 - Fixing more than one
  thing.  Should be two (2) PRs.
@pedrohdz
Copy link
Contributor Author

@jkschneider, Done... Thanks!

@jkschneider jkschneider added the ready to merge Approved and ready for merge label Aug 24, 2021
@mergify mergify bot merged commit 6013f49 into spinnaker:master Aug 24, 2021
@mergify mergify bot added the auto merged label Aug 24, 2021
pemmasanikrishna pushed a commit to pemmasanikrishna/front50 that referenced this pull request Sep 21, 2021
…ublic (spinnaker#1018)

This is an attempt to fix:

- spinnaker/spinnaker#5892
- spinnaker/spinnaker#6218

The following PRs attempted to address this issue, and appear to be
orphaned:

- spinnaker#900 - Failing checks.
- spinnaker#1002 - Fixing more than one
  thing.  Should be two (2) PRs.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
4 participants