fix(storage): Fix deserialization regression for storage services #1041
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…mixins classes to objectmappers used in storage services
ajordens
approved these changes
Jul 9, 2021
pemmasanikrishna
pushed a commit
to pemmasanikrishna/front50
that referenced
this pull request
Sep 21, 2021
…innaker#1041) * fix deserialization by adding Timestamped and Pipeline mixins classes to objectmappers used in storage services * add getters/setters for missing Pipeline properties * update pipeline serialization tests to include additional properties
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR resolves this issue: spinnaker/spinnaker#6468
This was introduced when I migrated Pipeline and Timestamped to a new front50-api package here: #1035
I needed to add the new Pipeline and Timestamped mixins to the other object mappers used for deserialization in the storage service classes.
There were also a few pipeline properties that were missing that needed to be added:
front50/front50-web/src/main/resources/graphql/pipelineConfig.graphqls
Line 12 in 9ed6b52