fix(api): remove JsonIgnore annotations to fix Pipeline deserialization regression #1042
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…to fix deserialization regression
pemmasanikrishna
pushed a commit
to pemmasanikrishna/front50
that referenced
this pull request
Sep 21, 2021
…to fix deserialization regression (spinnaker#1042)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This deserialization regression was introduced when I migrated the the
@jsonIgnoreannotations for the getter/setters in thefront50-corePipeline class to@JsonIgnorePropertieson the PipelineMixin class here: #1035.I got reports that pipelines were still producing errors due to missing fields and that the fields that we were supposed to ignore actually needed to be serialized/deserialized (ie name, application, etc). I checked out the previous code prior to the
front50-apipackage creation PR and noticed that the@jsonIgnorefield was masking behavior and wasn't actually ignoring those fields for serialization/deserialization.Introducing
@JsonIgnorePropertiesto the PipelineMixin class enforced the behavior of ignoring these fields, so I need to revert this back to the old behavior.Unfortunately I wasn't able to determine why
@JsonIgnorewasn't working prior to that PR with the time I had.