feat(plugin-registry): Front50 plugins storage service #625
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jonsie
force-pushed
the
front50-plugins-storage-service
branch
2 times, most recently
from
6fd29a0
to
2ef3985
Compare
cfieber
reviewed
Oct 31, 2019
front50-sql/src/main/kotlin/com/netflix/spinnaker/front50/model/SqlStorageService.kt
Outdated
Show resolved
Hide resolved
front50-sql/src/main/resources/db/changelog/20191030-initial-plugins-schema.yml
Outdated
Show resolved
Hide resolved
front50-core/src/main/groovy/com/netflix/spinnaker/front50/model/plugin/Plugin.java
Show resolved
Hide resolved
jonsie
force-pushed
the
front50-plugins-storage-service
branch
from
2ef3985
to
821b2b3
Compare
cfieber
reviewed
Oct 31, 2019
...core/src/main/groovy/com/netflix/spinnaker/front50/model/plugin/DefaultPluginRepository.java
Outdated
Show resolved
Hide resolved
cfieber
approved these changes
Oct 31, 2019
From what I can tell the non-SQL implementations should just work. I'll add a |
jonsie
force-pushed
the
front50-plugins-storage-service
branch
from
821b2b3
to
fd8dd36
Compare
cfieber
approved these changes
Nov 1, 2019
robzienert
requested changes
Nov 4, 2019
front50-sql/src/main/resources/db/changelog/20191030-initial-plugins-schema.yml
Outdated
Show resolved
Hide resolved
jonsie
force-pushed
the
front50-plugins-storage-service
branch
from
fd8dd36
to
e67e72d
Compare
6 tasks
|
Is this necessary? It may be too soon (or not necessary) to add this functionality to Front50, or it may be that this manifest can be greatly simplified. |
|
Closing for now. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Plain ol' JSON common storage service front50 implementation. Protobuf needs a bit of extra work to get it working with this implementation.
Previous PR: #621