Make role sync able to setup for each application permission and service account #995
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
I made a seperate API for configuring role sync for ApplicationPermissiond and ServiceAccount individually like below:
I've also refactored some tests.
Front50 access Fiat role/sync endpoint on application permission creation(which syncs all roles, very expensive endpoint) and service account creation(which only sync roles for specific roles, very light endpoint). I want to configure this seperatelly.
Why
Solves Make role sync settings to be configurable separately for service accounts and application permissions #6179.
If we disable
fiat.roleSync
, we will not be able to save the Spinnaker pipeline immediately after configuring the pipeline.On the other hand, if we enable it, sometimes cause a performance issue and consume Fiat resources a lot. This behavior is reported in the community slack. https://spinnakerteam.slack.com/archives/CC101KSNP/p1585589301029500?thread_ts=1585577275.028800&cid=CC101KSNP