Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make role sync able to setup for each application permission and service account #995

Conversation

KeisukeYamashita
Copy link
Member

@KeisukeYamashita KeisukeYamashita commented Nov 17, 2020

What

I made a seperate API for configuring role sync for ApplicationPermissiond and ServiceAccount individually like below:

fiat:
   roleSync:
       enabled: true|false  // for backward compatibility
       applicationPermission:
           enabled: true|false
       serviceAccount:
          enabled: true|false

I've also refactored some tests.

Front50 access Fiat role/sync endpoint on application permission creation(which syncs all roles, very expensive endpoint) and service account creation(which only sync roles for specific roles, very light endpoint). I want to configure this seperatelly.

Why

Solves Make role sync settings to be configurable separately for service accounts and application permissions #6179.

If we disable fiat.roleSync, we will not be able to save the Spinnaker pipeline immediately after configuring the pipeline.
On the other hand, if we enable it, sometimes cause a performance issue and consume Fiat resources a lot. This behavior is reported in the community slack. https://spinnakerteam.slack.com/archives/CC101KSNP/p1585589301029500?thread_ts=1585577275.028800&cid=CC101KSNP

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants