Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pause/resume endpoints #173

Merged
merged 1 commit into from
Jan 11, 2016
Merged

Pause/resume endpoints #173

merged 1 commit into from
Jan 11, 2016

Conversation

ajordens
Copy link
Contributor

@ajordens ajordens commented Jan 8, 2016

No description provided.

@ajordens
Copy link
Contributor Author

ajordens commented Jan 8, 2016

Consumed by deck and simple pass-throughs to orca ... not sold on /VERB but it does follow the same pattern as cancel.

Thoughts @robfletcher?

I could see /pipelines/{id}/actions w/ a PUT or POST payload of:

{
    action: "resume"
}

Seems a little nicer to me.

@robfletcher
Copy link
Contributor

LGTM, punch it Chewie!

@robfletcher
Copy link
Contributor

I think regarding the API consistency issue I'm a little torn. The purist in me says yes, we should do a PUT or POST with a payload. However, the guy who gets sick of having to dig in code to figure out how to do those kinds of requests says the way you've done it is more practical.

@robfletcher
Copy link
Contributor

Is there a way to actually specify the required payload with the Spring annotations so you can still have a separate controller method?

@ajordens
Copy link
Contributor Author

To your latter point, I don't think there is @robfletcher.

ajordens added a commit that referenced this pull request Jan 11, 2016
@ajordens ajordens merged commit c4ca24e into spinnaker:master Jan 11, 2016
@robfletcher
Copy link
Contributor

I don't think there is either which is pretty annoying

@spinnakerbot spinnakerbot mentioned this pull request Oct 12, 2022
@spinnakerbot spinnakerbot mentioned this pull request Nov 16, 2022
kirangodishala pushed a commit to kirangodishala/gate that referenced this pull request May 23, 2023
@spinnakerbot spinnakerbot mentioned this pull request May 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants