refactor(web): fix groovy compilation failure due to missing type conversions during upgrade to springboot 2.5.15 #1730
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…versions during upgrade to springboot 2.5.15
While upgrading springboot 2.5.15, encounter below error in gate-web module:
```
startup failed:
/gate/gate-web/src/main/groovy/com/netflix/spinnaker/gate/config/GateConfig.groovy: 231: [Static type checking] - Cannot call com.netflix.spinnaker.kork.web.selector.SelectableService#<init>(java.util.List <com.netflix.spinnaker.kork.web.selector.ServiceSelector>) with arguments [java.util.List <? extends com.netflix.spinnaker.kork.web.selector.ServiceSelector>]
@ line 231, column 9.
new SelectableService(selectors + defaultSelector), dynamicConfigService, contextProvider)
^
/gate/gate-web/src/main/groovy/com/netflix/spinnaker/gate/config/GateConfig.groovy: 322: [Static type checking] - Cannot find matching method java.lang.Object#configure(com.fasterxml.jackson.databind.SerializationFeature, boolean). Please check if the declared type is correct and if the method exists.
@ line 322, column 7.
objectMapper.configure(SerializationFeature.FAIL_ON_EMPTY_BEANS, false);
^
/gate/gate-web/src/main/groovy/com/netflix/spinnaker/gate/config/GateConfig.groovy: 324: [Static type checking] - Cannot find matching method com.netflix.spinnaker.kork.client.ServiceClientProvider#getService(java.lang.Class <T>, com.netflix.spinnaker.config.DefaultServiceEndpoint, T). Please check if the declared type is correct and if the method exists.
@ line 324, column 5.
serviceClientProvider.getService(type, new DefaultServiceEndpoint(serviceName, endpoint.url), objectMapper)
^
3 errors
> Task :gate-web:compileGroovy FAILED
```
To fix this, explicitly mentioned the type of object reference as `ServiceSelector defaultSelector` and typecasted the object `objectMapperBuilder.build() as ObjectMapper`.
dbyron-sf
reviewed
Nov 6, 2023
| @@ -317,7 +318,7 @@ class GateConfig extends RedisHttpSessionConfiguration { | |||
| } | |||
|
|
|||
| private <T> T buildService(String serviceName, Class<T> type, Endpoint endpoint) { | |||
| ObjectMapper objectMapper = objectMapperBuilder.build() | |||
| ObjectMapper objectMapper = objectMapperBuilder.build() as ObjectMapper | |||
There was a problem hiding this comment.
Would be so lovely to convert this to java one day.
dbyron-sf
approved these changes
Nov 6, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While upgrading springboot 2.5.15, encounter below error in gate-web module:
To fix this, explicitly mentioned the type of object reference as
ServiceSelector defaultSelectorand typecasted the objectobjectMapperBuilder.build() as ObjectMapper.