fix(credentials): Remove hystrix from CredentialsService
#518
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There is no longer a remote call in the direct call path of `CredentialsService.getAccounts()`, thus no need for hystrix. The `CredentialsService` was originally getting called for every x.509 authentication request. The default hystrix configuration had placed an artificial limit on the number of concurrent api requests that could be served by `gate`.
danielpeach
pushed a commit
to danielpeach/gate
that referenced
this pull request
May 24, 2018
…#518) There is no longer a remote call in the direct call path of `CredentialsService.getAccounts()`, thus no need for hystrix. The `CredentialsService` was originally getting called for every x.509 authentication request. The default hystrix configuration had placed an artificial limit on the number of concurrent api requests that could be served by `gate`.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There is no longer a remote call in the direct call path of
CredentialsService.getAccounts(), thus no need for hystrix.The
CredentialsServicewas originally getting called for every x.509authentication request. The default hystrix configuration had placed
an artificial limit on the number of concurrent api requests that could
be served by
gate.