fix(firewalls): enable retrieval of all firewalls in an account+region #793
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dbyron0
reviewed
May 8, 2019
| Map getSecurityGroups(@Path("account") String account, @Path("type") String type, @Query("region") String region) | ||
| Map getSecurityGroups(@Path("account") String account, @Path("type") String type) | ||
|
|
||
| @GET('/securityGroups/{account}/{type}') |
There was a problem hiding this comment.
Different path here than for getSecurityGroups?
There was a problem hiding this comment.
Same path, but with a query param (Clouddriver's API is not designed very well)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The firewalls endpoint claims you can get a list of firewalls filtered by account and region using a URL like this: https://gate/firewalls/myaccount?region=us-east-1
But that blows up because, when you add that query parameter Clouddriver returns a
List, not aMap, but Gate expects aMap.Obviously nobody is using the query parameter method, since it's never worked, so this is a good time to introduce a new endpoint (I'd like to use it in Deck to try to get away from some of the caching we're doing there).