Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(deploy/kubernetes): host alias support #1095

Merged
merged 1 commit into from Oct 30, 2018
Merged

feat(deploy/kubernetes): host alias support #1095

merged 1 commit into from Oct 30, 2018

Conversation

lwander
Copy link
Member

@lwander lwander commented Oct 30, 2018 

deploymentEnvironment:
  hostAliases:
    spin-clouddriver:
    - ip: "127.0.0.1"
      hostnames:
      - "local.local"

#1080

feat(deploy/kubernetes): host alias support
3f8307c 
```yaml
deploymentEnvironment:
  hostAliases:
    spin-clouddriver:
    - ip: "127.0.0.1"
      hostnames:
      - "local.local"
```
@lwander lwander requested a review from jtk54 October 30, 2018 17:40
jtk54
jtk54 approved these changes Oct 30, 2018
View reviewed changes
Copy link
Contributor

@jtk54 jtk54 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@lwander lwander merged commit e01dc7e into spinnaker:master Oct 30, 2018
@lwander lwander deleted the hostaliases branch October 30, 2018 18:20
@jtdawso jtdawso mentioned this pull request Nov 14, 2018
Closed
@rverma-nikiai
Copy link
Contributor

@jtk54 How can we leverage this pull request to add node-selector and tolerations for spinnaker deployment.

@rverma-nikiai
Copy link
Contributor

@jtk54 The issue was referenced to support pod toleration config, although I doubt how it can help. Can you please shade some light here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jtk54 jtk54 jtk54 approved these changes

Assignees
No one assigned
Labels
target-release/1.13
Projects
None yet
Milestone
No milestone
4 participants
@lwander @rverma-nikiai @jtk54 @spinnakerbot