Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixing the project logo #2097

Merged
merged 5 commits into from
Oct 5, 2023
Merged

Fixing the project logo #2097

merged 5 commits into from
Oct 5, 2023

Conversation

AnderMendoza
Copy link
Contributor

Hello, in this PR I am solving the error in loading the project logo, I am also adding a small style to the text.

Attached capture:
image

@spinnakerbot
Copy link
Contributor

The following commits need their title changed:

Please format your commit title into the form:

<type>(<scope>): <subject>, e.g. fix(kubernetes): address NPE in status check

This allows us to easily generate changelogs & determine semantic version numbers when cutting releases. You can read more about commit conventions here.

@AnderMendoza
Copy link
Contributor Author

AnderMendoza commented Oct 5, 2023

The following commits need their title changed:

Please format your commit title into the form:

<type>(<scope>): <subject>, e.g. fix(kubernetes): address NPE in status check

This allows us to easily generate changelogs & determine semantic version numbers when cutting releases. You can read more about commit conventions here.

It's done. @spinnakerbot

README.md Outdated
# Halyard

[![Build Status](https://api.travis-ci.org/spinnaker/halyard.svg?branch=master)](https://travis-ci.org/spinnaker/halyard)
<a href="https://app.travis-ci.com/spinnaker/halyard">
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Definitely appreciate improvements here. Turns out https://app.travis-ci.com/spinnaker/halyard is a dead link. We build with github actions these days. I'm all for including the logo though. Mind doing it on its own, without the travis link?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ok no problem

@dbyron-sf dbyron-sf added the ready to merge Approved and ready for a merge label Oct 5, 2023
@mergify mergify bot added the auto merged label Oct 5, 2023
@mergify mergify bot merged commit 8756637 into spinnaker:master Oct 5, 2023
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
3 participants