refactor(safeguard): Setting default high value on item threshold (#254)

spinnaker · Apr 5, 2018 · 5ae4fff · 5ae4fff
1 parent 72ab6b7
commit 5ae4fff
Show file tree

Hide file tree

Showing 2 changed files with 12 additions and 2 deletions.
diff --git a/igor-web/config/igor.yml b/igor-web/config/igor.yml
@@ -5,11 +5,20 @@ netflix:
 spinnaker:
   build:
     pollInterval: 30
+  pollingSafeguard:
+    # A lower value can help prevent accidental re-triggers of pipelines, but may require hands-on operations if
+    # set low.
+    # See code documentation for more details. Class [PollingSafeguardProperties] in
+    # https://github.com/spinnaker/igor/blob/master/igor-web/src/main/groovy/com/netflix/spinnaker/igor/IgorConfigurationProperties.groovy#L47
+    itemUpperThreshold: 1000
+
 
 endpoints.health.sensitive: false
 
 spring.jackson.serialization.write_dates_as_timestamps: false
 
+
+
 #artifact:
 #  This is a feature toggle for decoration of artifacts.
 #  decorator:

diff --git a/igor-web/src/main/groovy/com/netflix/spinnaker/igor/IgorConfigurationProperties.groovy b/igor-web/src/main/groovy/com/netflix/spinnaker/igor/IgorConfigurationProperties.groovy
@@ -48,9 +48,10 @@ class IgorConfigurationProperties {
             /**
              * Defines the upper threshold for number of new cache items before a cache update cycle will be completely
              * rejected. This is to protect against potentially re-indexing old caches due to downstream service errors.
-             * Once this threshold is tripped, API-driven resolution may be required.
+             * Once this threshold is tripped, API-driven resolution may be required. By default set higher than most
+             * use cases would require since it's a feature that requires more hands-on operations.
              */
-            int itemUpperThreshold = 10
+            int itemUpperThreshold = 1000
         }
 
         @NestedConfigurationProperty