refactor(travisclient): make changes to travisClient to use Spinnaker custom exception instead of RetrofitError using SpinnakerRetrofitErrorHandler #1090
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Luthan95
force-pushed
the
travis_client_user_exception_handling_for_retrofiterror
branch
2 times, most recently
from
3bfac44
to
2dcf5c0
Compare
dbyron-sf
reviewed
Mar 24, 2023
igor-monitor-travis/src/main/java/com/netflix/spinnaker/igor/travis/service/TravisService.java
Outdated
Show resolved
Hide resolved
Luthan95
force-pushed
the
travis_client_user_exception_handling_for_retrofiterror
branch
2 times, most recently
from
f15a3be
to
5a9efc6
Compare
SheetalAtre
force-pushed
the
travis_client_user_exception_handling_for_retrofiterror
branch
4 times, most recently
from
7a71112
to
aa4f0bc
Compare
dbyron-sf
reviewed
Sep 10, 2023
igor-monitor-travis/src/main/java/com/netflix/spinnaker/igor/travis/service/TravisService.java
Outdated
Show resolved
Hide resolved
dbyron-sf
reviewed
Sep 11, 2023
igor-monitor-travis/src/main/java/com/netflix/spinnaker/igor/travis/service/TravisService.java
Outdated
Show resolved
Hide resolved
…rofitErrorHandler for custom error handling in travis client
refactor(travisService/test): response body could be null for eg when a json converter is unable to convert non-json format
SheetalAtre
force-pushed
the
travis_client_user_exception_handling_for_retrofiterror
branch
from
f88bf13
to
9f17d8b
Compare
dbyron-sf
reviewed
Sep 14, 2023
| } catch (RuntimeException ex) { | ||
| log.warn("{}: Could not parse original error message from Travis", groupKey, ex); | ||
| } catch (SpinnakerServerException e) { | ||
| if (e instanceof SpinnakerHttpException) { // only SpinnakerHttpException has a response body |
There was a problem hiding this comment.
What you've got here matches the current behavior, but...I'm tempted to clean up this code and change the behavior all at the same time.
If I'm reading the code correctly, the current behavior swallows an RetrofitError that has a null body. That seems a little unfortunate.
If we change this to catch SpinnakerHttpException instead of SpinnakerServerException, we let the other exception types bubble up. That feels like better behavior. But, this PR has lived a long time, and I don't have a good way to exercise this specific functionality so let's leave this for another time.
dbyron-sf
approved these changes
Sep 14, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To make use of custom spinnaker exception instead of RetrofitError using SpinnakerRetrofitErrorHandler present in kork service, to rectify dependency of RetrofitError class