refactor(Githubclient): make changes to Git(master|lab) and BitBucket… #1104
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Luthan95
force-pushed
the
custom_exception_handling_gitclient
branch
from
9508bfa
to
7824fce
Compare
Luthan95
force-pushed
the
custom_exception_handling_gitclient
branch
from
7824fce
to
b920f8d
Compare
SheetalAtre
force-pushed
the
custom_exception_handling_gitclient
branch
4 times, most recently
from
e2a2b22
to
d337376
Compare
dbyron-sf
reviewed
Sep 10, 2023
igor-web/src/main/groovy/com/netflix/spinnaker/igor/gitlabci/service/GitlabCiService.java
Outdated
Show resolved
Hide resolved
dbyron-sf
reviewed
Sep 10, 2023
igor-web/src/main/groovy/com/netflix/spinnaker/igor/gitlabci/service/GitlabCiService.java
Outdated
Show resolved
Hide resolved
dbyron-sf
reviewed
Sep 10, 2023
igor-web/src/main/groovy/com/netflix/spinnaker/igor/scm/github/CommitController.groovy
Show resolved
Hide resolved
SheetalAtre
force-pushed
the
custom_exception_handling_gitclient
branch
2 times, most recently
from
e5841f6
to
f225284
Compare
|
@Mergifyio update |
✅ Branch has been successfully updated |
dbyron-sf
reviewed
Sep 14, 2023
igor-web/src/main/groovy/com/netflix/spinnaker/igor/gitlabci/service/GitlabCiService.java
Show resolved
Hide resolved
dbyron-sf
reviewed
Sep 14, 2023
| throw ex; | ||
| e.setRetryable(false); | ||
| throw e; | ||
| } catch (SpinnakerServerException e) { |
There was a problem hiding this comment.
I suppose this is faithful to the original behavior, but it doesn't seem right...a note for our future selves.
dbyron-sf
reviewed
Sep 14, 2023
igor-web/src/main/groovy/com/netflix/spinnaker/igor/scm/github/CommitController.groovy
Outdated
Show resolved
Hide resolved
dbyron-sf
reviewed
Sep 14, 2023
igor-web/src/main/groovy/com/netflix/spinnaker/igor/scm/github/CommitController.groovy
Outdated
Show resolved
Hide resolved
dbyron-sf
reviewed
Sep 14, 2023
igor-web/src/main/groovy/com/netflix/spinnaker/igor/scm/github/CommitController.groovy
Show resolved
Hide resolved
dbyron-sf
reviewed
Sep 14, 2023
igor-web/src/main/groovy/com/netflix/spinnaker/igor/scm/github/client/GitHubMaster.groovy
Outdated
Show resolved
Hide resolved
dbyron-sf
reviewed
Sep 14, 2023
igor-web/src/main/java/com/netflix/spinnaker/igor/scm/ManagedDeliveryScmController.java
Outdated
Show resolved
Hide resolved
SheetalAtre
force-pushed
the
custom_exception_handling_gitclient
branch
2 times, most recently
from
e0e6249
to
289916b
Compare
dbyron-sf
reviewed
Sep 15, 2023
igor-web/src/main/groovy/com/netflix/spinnaker/igor/scm/github/CommitController.groovy
Show resolved
Hide resolved
…Handler for custom error handling in Github, GitlabCi, BitBucket, ManagedScmDelivery
…HttpException exceptions for readability
…mpile error in ManagedDeliveryScmController
SheetalAtre
force-pushed
the
custom_exception_handling_gitclient
branch
from
289916b
to
5986a78
Compare
…ed missing line for GitHubCommitController in catch of SpinnakerServerException
…: change Spinnaker*Exception handling code for readability
…scm/github/CommitController.compareCommits to clean up the code / reduce instanceof checks
dbyron-sf
reviewed
Sep 19, 2023
igor-web/src/main/groovy/com/netflix/spinnaker/igor/scm/github/client/GitHubMaster.groovy
Outdated
Show resolved
Hide resolved
…/client/GitHubMaster.groovy
dbyron-sf
approved these changes
Sep 19, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
… to use Spinnaker custom exception instead of RetrofitError using SpinnakerRetrofitErrorHandler
Make use of custom spinnaker exceptions from kork service to avoid direct usage of RetrofitError using SpinnakerRetrofitErrorHandler for Git(master|lab) and BitBucket to achieve a common approach around all services