Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor(StashClient,WerckerClient/test): make changes to StashClient, WerckerClient use customSpinnaker Exceptions using SpinnakerRetrofitErrorHandler #1128

Merged
merged 6 commits into from
Sep 19, 2023
Merged

refactor(StashClient,WerckerClient/test): make changes to StashClient, WerckerClient use customSpinnaker Exceptions using SpinnakerRetrofitErrorHandler #1128

merged 6 commits into from
Sep 19, 2023

Conversation

SheetalAtre
Copy link
Contributor

@SheetalAtre SheetalAtre commented May 19, 2023 •
edited
Loading

refactor(StashClient,WerckerClient/test): make changes to StashClient, WerckerClient use customSpinnaker Exceptions using SpinnakerRetrofitErrorHandler
make use of SpinnakerRetrofitErrorHandler to utilize custom spinnaker exception and replace RetrofitError

@spinnakerbot
Copy link
Contributor

The following commits need their title changed:

  • 21947a8: refactor(igor):Replace StashClient,WerckerClient RetrofitError with custom exceptions

Please format your commit title into the form:

<type>(<scope>): <subject>, e.g. fix(kubernetes): address NPE in status check

This allows us to easily generate changelogs & determine semantic version numbers when cutting releases. You can read more about commit conventions here.

@Luthan95 Luthan95 force-pushed the stash_client_werker_client_replace_retrofiterror_with_custom_exceptions branch from 21947a8 to fa40816 Compare May 19, 2023 17:51
@SheetalAtre SheetalAtre force-pushed the stash_client_werker_client_replace_retrofiterror_with_custom_exceptions branch 3 times, most recently from f587d21 to be4749c Compare August 30, 2023 04:50
@SheetalAtre SheetalAtre changed the title refactor(igor):Replace StashClient,WerckerClient RetrofitError with custom exceptions refactor(StashClient,WerckerClient/test): make changes to StashClient, WerckerClient use customSpinnaker Exceptions using SpinnakerRetrofitErrorHandler Sep 11, 2023
@SheetalAtre SheetalAtre force-pushed the stash_client_werker_client_replace_retrofiterror_with_custom_exceptions branch from be4749c to 3cee198 Compare September 11, 2023 16:33
@SheetalAtre SheetalAtre force-pushed the stash_client_werker_client_replace_retrofiterror_with_custom_exceptions branch 2 times, most recently from 1aafe9f to ffc3548 Compare September 19, 2023 06:25
@SheetalAtre
refactor(StashClient,WerckerClient/test): replace RetrofitError with …
01c3c31 
…SpinnakerRetrofitErrorHandler for custom error handling in StashClient, WerckerClient
@SheetalAtre
refactor(StashClient,WerckerClient): separate catch blocks for Spinna…
85733c6 
…kerNetworkException for readability
@SheetalAtre
refactor(WerckerClient): extract url from SpinnakerHttpException for …
7989d97 
…WerckerBuildMonitor process pipeline runs
@SheetalAtre
refactor(WerckerService): behavior change, when triggerBuildWithParam…
1d99317 
…eters throws SpinnakerServerException, err log shows exception err msg, because SpinnakerHttpException response body raw contents are not accessible
@SheetalAtre
refactor(WerckerClient): move try block to handle exception from werc…
6a89998 
…kerService.getBuilds(pipeline), and add separate catch block for SpinnakerServerException as e.getCause() may be relevant for non-SpinnakerHttpException-eg cause for IOException could be SocketTimeoutException/ConnectException
@SheetalAtre SheetalAtre force-pushed the stash_client_werker_client_replace_retrofiterror_with_custom_exceptions branch from 0861fa3 to 6a89998 Compare September 19, 2023 19:14
@SheetalAtre
refactor(WerckerClient): Remove if-else block related to e.getUrl() a…
919546d 
…nd e.getCause(), since Spinnaker*Exception contains relevant info in the exception message, which is already handled in existing log message
@dbyron-sf dbyron-sf marked this pull request as ready for review September 19, 2023 19:27
@dbyron-sf dbyron-sf added the ready to merge Approved and ready for merge label Sep 19, 2023
@mergify mergify bot added the auto merged label Sep 19, 2023
@mergify mergify bot merged commit 23be630 into spinnaker:master Sep 19, 2023
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dbyron-sf dbyron-sf dbyron-sf approved these changes

Assignees
No one assigned
Labels
auto merged ready to merge Approved and ready for merge target-release/1.33
Projects
None yet
Milestone
No milestone
3 participants
@SheetalAtre @spinnakerbot @dbyron-sf