Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(docker): reverting default containers to java 11 #1168

Closed
wants to merge 2 commits into from

Conversation

nemesisOsorio
Copy link
Member

@nemesisOsorio nemesisOsorio commented Sep 14, 2023

Partially reverting #1143

I tried to upgrade to Java 17 but it will need more time, and containers for Java 11 will not work

Fixes spinnaker/spinnaker#6879

@nemesisOsorio
Copy link
Member Author

@dbyron-sf @mattgogerly can you please take a look?

@dbyron-sf
Copy link
Contributor

Really hoping we hear from @mattgogerly before merging this....or perhaps someone else has tried to fix the issue?

@nemesisOsorio
Copy link
Member Author

Really hoping we hear from @mattgogerly before merging this....or perhaps someone else has tried to fix the issue?

I believe we need to move completely to Java 17 to fix the issue and remove docker builds for Java 11

@dbyron-sf
Copy link
Contributor

Really hoping we hear from @mattgogerly before merging this....or perhaps someone else has tried to fix the issue?

I believe we need to move completely to Java 17 to fix the issue and remove docker builds for Java 11

If that's true (and it totally could be, I haven't looked into it), that's a pretty big change to the plan in https://github.com/spinnaker/governance/blob/master/rfc/java17.md, yes?

@nemesisOsorio
Copy link
Member Author

Really hoping we hear from @mattgogerly before merging this....or perhaps someone else has tried to fix the issue?

I believe we need to move completely to Java 17 to fix the issue and remove docker builds for Java 11

If that's true (and it totally could be, I haven't looked into it), that's a pretty big change to the plan in https://github.com/spinnaker/governance/blob/master/rfc/java17.md, yes?

yes, it is a big change, I already tried running igor with Java 17

Copy link
Contributor

@dbyron-sf dbyron-sf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@mattgogerly is back Monday and I believe has a smaller fix that allows us to keep java 17. Let's hold off til we hear from him.

@dbyron-sf
Copy link
Contributor

handled by #1170

@dbyron-sf dbyron-sf closed this Sep 18, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants