chore(dependencies): Autobump korkVersion #1188
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
spinnakerbot
force-pushed
the
autobump-korkVersion-master
branch
from
b763f83
to
d88429d
Compare
…OfProject The jenkinsClient inside JenkinsService comes from JenkinsConfig, wihch, as of spinnaker#1130, uses SpinnakerRetrofitErrorHandler. Therefore, the getBuilds calls inside the try/catch block inside processBuildsOfProject throws a SpinnakerServerException. spinnaker#1130 updated the 'should continue processing other builds from a master even if one or more build fetches fail' test to throw a SpinnakerServerException with a RetrofitError as its cause instead of a RuntimeException with a RetrofitError as its cause. With spinnaker/kork#1110, the SpinnakerServerException no longer has a RetrofitError as its cause. It has the "mock root cause" exception as its cause. But, because spinnaker/kork#1110 adds a url attribute to SpinnakerServerException, the cause is no longer necessary for including a url in the "Error communicating with jenkins" log message, and this commit updates the logic accordingly.
…Spec remove unused runtimeException and rename retrofitEx since it's no longer a retrofitEx
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.