Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(java17): compile with JDK17 targeting Java 11 bytecode #1198

Merged
merged 3 commits into from Mar 23, 2024
Merged

Conversation

mattgogerly
Copy link
Member

@mattgogerly mattgogerly commented Nov 30, 2023

DO NOT MERGE PRE-1.33

  • Swap the setup-java versions around so that 17 comes first on the PATH.
  • Update build commands to enable cross compilation plugin.

Build should pass once spinnaker/spinnaker-gradle-project#203 and spinnaker/spinnaker-gradle-project#204 are both merged.

Confirmed it's working with targetJava17=false:

javap -v igor-web/build/classes/groovy/main/com/netflix/spinnaker/igor/Main | grep major
Warning: File ./igor-web/build/classes/groovy/main/com/netflix/spinnaker/igor/Main.class does not contain class igor-web/build/classes/groovy/main/com/netflix/spinnaker/igor/Main
  major version: 55

and true:

javap -v igor-web/build/classes/groovy/main/com/netflix/spinnaker/igor/Main | grep major
Warning: File ./igor-web/build/classes/groovy/main/com/netflix/spinnaker/igor/Main.class does not contain class igor-web/build/classes/groovy/main/com/netflix/spinnaker/igor/Main
  major version: 61

@dbyron-sf
Copy link
Contributor

Is the idea to wait on merging this until 1.33 appears?

@mattgogerly
Copy link
Member Author

mattgogerly commented Nov 30, 2023

Is the idea to wait on merging this until 1.33 appears?

Correct, just trying to figure out what needs fixing now to get a headstart.

@mattgogerly mattgogerly marked this pull request as ready for review March 22, 2024 16:36
@mattgogerly mattgogerly added the ready to merge Approved and ready for merge label Mar 23, 2024
@mergify mergify bot added the auto merged label Mar 23, 2024
@mergify mergify bot merged commit 0c564b4 into master Mar 23, 2024
5 checks passed
@mattgogerly mattgogerly deleted the feat/jre17 branch March 23, 2024 00:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
3 participants