fix(gcb): Correctly fetch artifact manifest when it contains a version #468
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The logic to fetch an artifact manifest does not properly account for the GCS path containing a version (as in gs://bucket/file.json#123). This isn't causing any active issues as GCB creates a file named with a UUID and does not include the version in the build output, but we should properly handle this in case this changes (or in case we re-use the artifact fetching code elsewhere).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The logic to fetch an artifact manifest does not properly account for the GCS path containing a version (as in gs://bucket/file.json#123).
This isn't causing any active issues as GCB creates a file named with a UUID and does not include the version in the build output, but we should properly handle this in case this changes (or in case we re-use the artifact fetching code elsewhere).