fix(jenkins): don't npe on dynamic choice parameters #502
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
robzienert
reviewed
Sep 4, 2019
| if (matchingParam != null && | ||
| parameterDefinition.type == 'ChoiceParameterDefinition' && | ||
| parameterDefinition.choices != null && | ||
| !parameterDefinition.choices.contains(matchingParam)) { |
There was a problem hiding this comment.
- For long conditions such as this, I like to break them out into a separate (static whenever possible) method.
- Test
There was a problem hiding this comment.
I feel like since this is already a part of a small static method i'll just add a test for that method. sound ok?
There was a problem hiding this comment.
Sounds legit, I didn't notice how small this method was already.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In Jenkins, you can have a "dynamic choice parameter". This means that you can write a script to generate all the dropdown choices for a parameter. It seems like this script is only run when you hit "build with parameters". When you query for the job config (
https://jenkins-controller/job/job-name//api/xml?exclude=/*/action&exclude=/*/build&exclude=/*/property[not(parameterDefinition)]) you actually get no choices. Better yet, instead of an empty list,choicesis null!This PR makes adds a null check to
parameterDefinition.choicesso that if it'snullwe just don't validate. Right now we throw anNPE.