fix(travis): Correctly parse global_env from Travis v3 API #504
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When the `config` section is returned as part of a *build* (which is unsupported in the Travis v3 API), `global_env` is a list of Strings. When it is returned as part of a *job*, `global_env` is instead a space separated String. And since env variable values can also contain spaces and equal signs, I had to create a little regex parser thingy. This also fixes an issue in Deck where you can't add parameters to a Travis stage if `.travis.yml` contains anything in the `env.global` section.
jervi
force-pushed
the
fix_travis_property_parsing
branch
from
73e6b1a
to
b04836c
Compare
|
@spinnaker/reviewers PTAL |
emjburns
approved these changes
Sep 13, 2019
| @SuppressWarnings("unchecked") | ||
| public void setGlobalEnv(Object globalEnv) { | ||
| if (globalEnv == null) { | ||
| this.globalEnv = null; |
There was a problem hiding this comment.
I think I'd remove this initial null check & assignment. I don't think you need a null check before using instanceOf, and I think the variable will be null by default?
There was a problem hiding this comment.
Thanks, you're right, and I've updated the PR 👍
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When the
configsection is returned as part of a build (which is unsupported in the Travis v3 API),global_envis a list of Strings. When it is returned as part of a job,global_envis instead a space separated String. And since env variable values can also contain spaces and equal signs, I had to create a little regex parser thingy.This also fixes an issue in Deck where you can't add parameters to a Travis stage if
.travis.ymlcontains anything in theenv.globalsection.