feat(gcb): Add permissioning to Google Cloud Build accounts #523
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi @ezimanyi , this is the PR as per our discussion in spinnaker/spinnaker#4814 . Please let me know what do you think. I did a bit of manual testing in my local environment and it seems working all right. |
afcastano
force-pushed
the
master
branch
4 times, most recently
from
2cfa273
to
2c17d68
Compare
ezimanyi
approved these changes
Oct 23, 2019
| @@ -69,6 +70,9 @@ class InfoController { | |||
| @Autowired(required = false) | |||
| ConcourseProperties concourseProperties | |||
|
|
|||
| @Autowired(required =false) | |||
There was a problem hiding this comment.
Minor: missing space after =
afcastano
force-pushed
the
master
branch
4 times, most recently
from
563dcb5
to
b8cd73a
Compare
Co-authored-by: Sirisha Vadrevu <sirishavadrevu@gmail.com>
Added missing whitespace
|
Great, thanks @ezimanyi, the minor fix is done. =) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added permissioning to Google Cloud Build accounts.
It solves spinnaker/spinnaker#4814
Protects the gcb accounts so that only defined roles can READ and WRITE.