feat(keel): send keel docker events if enabled #535
Conversation
emjburns
force-pushed
the
container-events-to-keel
branch
from
ca9c973
to
beee95c
Compare
| payload: [artifacts: [artifact], details: [:]], | ||
| eventName: "spinnaker_artifacts_docker" | ||
| ] | ||
| AuthenticatedRequest.allowAnonymous { keelService.get().sendArtifactEvent(artifactEvent) } |
There was a problem hiding this comment.
Is the allowAnonymous bit common practice/OK?
There was a problem hiding this comment.
It's common for service to service calls, i.e. we're not doing this call on behalf of a user so we have no user auth info to pass on.
|
P.S. Sorry if this is a silly question, but if we were already sending an event to echo, and echo centralizes most event handling to/from other services, shouldn鈥檛 we just extend the event handler in echo to call keel? |
|
@luispollo that's a good question. Since the information is coming from |
|
BTW @emjburns I noticed that this echo PR from earlier this year introduced echo -> keel integration for artifact events. How does that relate to/differ from what we're trying to accomplish here? |
igor-web/src/main/java/com/netflix/spinnaker/igor/config/KeelConfig.java
Outdated
Show resolved
Hide resolved
igor-web/src/main/groovy/com/netflix/spinnaker/igor/docker/DockerMonitor.groovy
Outdated
Show resolved
Hide resolved
|
(answered Luis's questions offline) |
emjburns
force-pushed
the
container-events-to-keel
branch
from
2c9b7e3
to
72ded70
Compare
In order to react to new docker containers in
keelwe need to know when there are new containers. This PR adds functionality to emit events tokeelwith the same criteria as sending new events to echo.This won't kick in unless you have keel enabled. The format for the docker event we send is subject to change, but I think this is a decent first start 馃し鈥嶁檧 we shall see.