Skip to content

Commit

Permalink
fix(kayenta): Fixes generated pom.xml to omit invalid declaration of …
Browse files Browse the repository at this point in the history
…lombok (#582)

compileOnly dependency should not be added to generated pom.xml,
see discussion: https://discuss.gradle.org/t/publishing-plugin-should-respect-compileonly-configuration/22903/2
see related commit: nebula-plugins/nebula-publishing-plugin@a5432aa
  • Loading branch information
Nastya Smirnova authored and marchello2000 committed Jul 3, 2019
1 parent 8354824 commit 5cadcc1
Show file tree
Hide file tree
Showing 2 changed files with 3 additions and 6 deletions.
3 changes: 3 additions & 0 deletions build.gradle
Original file line number Diff line number Diff line change
Expand Up @@ -25,6 +25,9 @@ buildscript {
classpath "com.netflix.spinnaker.gradle:spinnaker-dev-plugin:$spinnakerGradleVersion"
if (Boolean.valueOf(enablePublishing)) {
classpath "com.netflix.spinnaker.gradle:spinnaker-gradle-project:$spinnakerGradleVersion"
// TODO: nebula-publishing-plugin version override should be removed as soon as spinnaker-gradle-project is updated
// this override is needed to omit compileOnly dependencies from generated pom.xml
classpath "com.netflix.nebula:nebula-publishing-plugin:12.0.1"
}

classpath "com.netflix.nebula:nebula-kotlin-plugin:$kotlinVersion"
Expand Down
6 changes: 0 additions & 6 deletions kayenta-bom/kayenta-bom.gradle
Original file line number Diff line number Diff line change
Expand Up @@ -17,16 +17,10 @@
apply plugin: "java-platform"
apply plugin: "maven-publish"

// without this building the pom fails when using the Nebula publishing plugin
configurations {
create("compileOnly")
}

javaPlatform {
allowDependencies()
}


if (Boolean.valueOf(enablePublishing)) {
publishing {
publications {
Expand Down

0 comments on commit 5cadcc1

Please sign in to comment.