fix a few overridden with missing annotation warnings (#147)

spinnaker · Dec 7, 2017 · d59a351 · d59a351
1 parent ebce2b5
commit d59a351
Show file tree

Hide file tree

Showing 6 changed files with 21 additions and 6 deletions.
diff --git a/kayenta-atlas/src/main/java/com/netflix/kayenta/atlas/orca/AtlasFetchStage.java b/kayenta-atlas/src/main/java/com/netflix/kayenta/atlas/orca/AtlasFetchStage.java
@@ -22,17 +22,20 @@
 import org.springframework.context.annotation.Bean;
 import org.springframework.stereotype.Component;
 
+import javax.annotation.Nonnull;
+
 @Component
 public class AtlasFetchStage {
 
   @Bean
   StageDefinitionBuilder atlasFetchStageBuilder(){
     return new StageDefinitionBuilder() {
       @Override
-      public void taskGraph(Stage stage, TaskNode.Builder builder) {
+      public void taskGraph(@Nonnull Stage stage, @Nonnull TaskNode.Builder builder) {
         builder.withTask("atlasFetch", AtlasFetchTask.class);
       }
 
+      @Nonnull
       @Override
       public String getType() {
         return "atlasFetch";

diff --git a/kayenta-atlas/src/main/java/com/netflix/kayenta/atlas/orca/AtlasFetchTask.java b/kayenta-atlas/src/main/java/com/netflix/kayenta/atlas/orca/AtlasFetchTask.java
@@ -33,6 +33,7 @@
 import org.springframework.beans.factory.annotation.Autowired;
 import org.springframework.stereotype.Component;
 
+import javax.annotation.Nonnull;
 import java.io.IOException;
 import java.time.Duration;
 import java.util.Collections;
@@ -79,8 +80,9 @@ public long getDynamicBackoffPeriod(Duration taskDuration) {
     return Duration.ofSeconds(backoffPeriodSeconds).toMillis();
   }
 
+  @Nonnull
   @Override
-  public TaskResult execute(Stage stage) {
+  public TaskResult execute(@Nonnull Stage stage) {
     Map<String, Object> context = stage.getContext();
     String metricsAccountName = (String)context.get("metricsAccountName");
     String storageAccountName = (String)context.get("storageAccountName");

diff --git a/...ta-prometheus/src/main/java/com/netflix/kayenta/prometheus/orca/PrometheusFetchStage.java b/...ta-prometheus/src/main/java/com/netflix/kayenta/prometheus/orca/PrometheusFetchStage.java
@@ -22,17 +22,20 @@
 import org.springframework.context.annotation.Bean;
 import org.springframework.stereotype.Component;
 
+import javax.annotation.Nonnull;
+
 @Component
 public class PrometheusFetchStage {
 
   @Bean
   StageDefinitionBuilder prometheusFetchStageBuilder(){
     return new StageDefinitionBuilder() {
       @Override
-      public void taskGraph(Stage stage, TaskNode.Builder builder) {
+      public void taskGraph(@Nonnull Stage stage, @Nonnull TaskNode.Builder builder) {
         builder.withTask("prometheusFetch", PrometheusFetchTask.class);
       }
 
+      @Nonnull
       @Override
       public String getType() {
         return "prometheusFetch";

diff --git a/...nta-prometheus/src/main/java/com/netflix/kayenta/prometheus/orca/PrometheusFetchTask.java b/...nta-prometheus/src/main/java/com/netflix/kayenta/prometheus/orca/PrometheusFetchTask.java
@@ -32,6 +32,7 @@
 import org.springframework.beans.factory.annotation.Autowired;
 import org.springframework.stereotype.Component;
 
+import javax.annotation.Nonnull;
 import java.io.IOException;
 import java.time.Duration;
 import java.util.Collections;
@@ -68,8 +69,9 @@ public long getTimeout() {
     return Duration.ofMinutes(2).toMillis();
   }
 
+  @Nonnull
   @Override
-  public TaskResult execute(Stage stage) {
+  public TaskResult execute(@Nonnull Stage stage) {
     Map<String, Object> context = stage.getContext();
     String metricsAccountName = (String)context.get("metricsAccountName");
     String storageAccountName = (String)context.get("storageAccountName");

diff --git a/...stackdriver/src/main/java/com/netflix/kayenta/stackdriver/orca/StackdriverFetchStage.java b/...stackdriver/src/main/java/com/netflix/kayenta/stackdriver/orca/StackdriverFetchStage.java
@@ -22,17 +22,20 @@
 import org.springframework.context.annotation.Bean;
 import org.springframework.stereotype.Component;
 
+import javax.annotation.Nonnull;
+
 @Component
 public class StackdriverFetchStage {
 
   @Bean
   StageDefinitionBuilder stackdriverFetchStageBuilder(){
     return new StageDefinitionBuilder() {
       @Override
-      public void taskGraph(Stage stage, TaskNode.Builder builder) {
+      public void taskGraph(@Nonnull Stage stage, @Nonnull TaskNode.Builder builder) {
         builder.withTask("stackdriverFetch", StackdriverFetchTask.class);
       }
 
+      @Nonnull
       @Override
       public String getType() {
         return "stackdriverFetch";

diff --git a/...-stackdriver/src/main/java/com/netflix/kayenta/stackdriver/orca/StackdriverFetchTask.java b/...-stackdriver/src/main/java/com/netflix/kayenta/stackdriver/orca/StackdriverFetchTask.java
@@ -32,6 +32,7 @@
 import org.springframework.beans.factory.annotation.Autowired;
 import org.springframework.stereotype.Component;
 
+import javax.annotation.Nonnull;
 import java.io.IOException;
 import java.time.Duration;
 import java.util.Collections;
@@ -66,8 +67,9 @@ public long getTimeout() {
     return Duration.ofMinutes(2).toMillis();
   }
 
+  @Nonnull
   @Override
-  public TaskResult execute(Stage stage) {
+  public TaskResult execute(@Nonnull Stage stage) {
     Map<String, Object> context = stage.getContext();
     String metricsAccountName = (String)context.get("metricsAccountName");
     String storageAccountName = (String)context.get("storageAccountName");