Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(init): Move configuration finalization out of Main #1023

Merged
merged 1 commit into from
Apr 14, 2020

Conversation

luispollo
Copy link
Contributor

Really fixes #1015 (hopefully).

log.info("Using artifact handlers: {}", artifactHandlers.joinToString { it.name })
}
}
class KeelApplication
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That is one skinny class!

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I know, right?! But it pulls in all the rest... 🤷

Copy link
Contributor

@lorin lorin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

@luispollo luispollo added the ready to merge Approved and ready for merge label Apr 14, 2020
@mergify mergify bot merged commit a3e7bfb into spinnaker:master Apr 14, 2020
@mergify mergify bot added the auto merged label Apr 14, 2020
@luispollo luispollo deleted the fix-spring-init branch April 14, 2020 23:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
auto merged ready to merge Approved and ready for merge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

InvalidTypeIdException thrown after kork version bump
2 participants