Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix wrong type of providers.aws.bakeryDefaults.baseImages[].virtualizationSettings #175

Merged
merged 3 commits into from
May 18, 2021

Commits on May 14, 2021

  1. Change type of `providers.aws.bakeryDefaults.baseImages[].virtualizat…

    …ionSettings` as repeated value
    
    Rosco manages `virtualizationSettings` for `aws` as a list of settings where
    an item contains regional VM settings, like follows.
    
        aws:
          bakeryDefaults:
            baseImages:
            - baseImage:
                id: ubuntu
                shortDescription: v12.04
                detailedDescription: Ubuntu Precise Pangolin v12.04
                packageType: deb
                templateFile: aws-ebs.json
              virtualizationSettings:
              - region: us-east-1
                virtualizationType: hvm
                instanceType: t2.micro
                sourceAmi: ami-d4aed0bc
                sshUserName: ubuntu
                spotPrice: "0"
                spotPriceAutoProduct: Linux/UNIX (Amazon VPC)
    
    I have confirmed that testdata also contains wrong schema around
    `virtualizationSettings`. As long as I could confirm from Rosco
    implementation, it had `virtualizationSettings` was typed as
     `List<AWSVirtuzliationSettings>`, therefore, I do believe
    this is mistake while generating testdata for `aws` provider.
    
        static class AWSBakeryDefaults {
          String awsAccessKey
          String awsSecretKey
          String awsSubnetId
          String awsVpcId
          Boolean awsAssociatePublicIpAddress
          String templateFile
          BakeRequest.VmType defaultVirtualizationType
          List<AWSOperatingSystemVirtualizationSettings> baseImages = []
        }
    
        static class AWSOperatingSystemVirtualizationSettings {
          BakeOptions.BaseImage baseImage
          List<AWSVirtualizationSettings> virtualizationSettings = []
        }
    
    https://github.com/spinnaker/rosco/blob/version-0.25.0/rosco-core/src/main/groovy/com/netflix/spinnaker/rosco/providers/aws/config/RoscoAWSConfiguration.groovy#L65
    yyuu committed May 14, 2021
    Configuration menu
    Copy the full SHA
    9214a84 View commit details
    Browse the repository at this point in the history

Commits on May 15, 2021

  1. Fix broken test after changing `providers.aws.bakeryDefaults.baseImag…

    …es[].virtualizationSettings` as plural
    yyuu committed May 15, 2021
    Configuration menu
    Copy the full SHA
    6cb5ff8 View commit details
    Browse the repository at this point in the history

Commits on May 18, 2021

  1. Configuration menu
    Copy the full SHA
    8095e22 View commit details
    Browse the repository at this point in the history